Recent changes to bugs

NullPointer Exception due to getFile()

Anonymous — Tue, 26 Jun 2012 10:44:27 -0000

package com.webcodepro.applecommander.storage.os.cpm
class CpmFormatDisk

/**
* Create a new FileEntry.
* @see com.webcodepro.applecommander.storage.DirectoryEntry#createFile()
*/
public FileEntry createFile() throws DiskFullException {
return null;
}

instead of "return null" this should be
throw new DiskFullException(textBundle.get("FileCreationNotSupported")); //$NON-NLS-1$
as in the other implementations instead. Otherwise clients face unexpected NullPointer exception.

Best regards, Peter.

NullPointer Exception due to getFormattedDisks()

Anonymous — Thu, 21 Jun 2012 15:43:32 -0000

When using -l on an invalid disk image we get:

Error: null
java.lang.NullPointerException
at com.webcodepro.applecommander.ui.ac.showDirectory(Unknown Source)
at com.webcodepro.applecommander.ui.ac.main(Unknown Source)
at com.webcodepro.applecommander.ui.AppleCommander.main(Unknown Source)

Reason is in class Dsik:
/**
* Determine type of disk, and return the appropriate
* FormattedDisk object. Returns null if none are
* recognized.
*/
public FormattedDisk[] getFormattedDisks() {

But none of the calling locations deals with null, they all expect an empty array instead.
So I'd suggest to change return null to return new FormattedDisk[0].

Best regards, Peter.

Pascal 800K disks only hold 140K

John B. Matthews — Sat, 24 May 2008 16:55:49 -0000

Pascal 800K disks only hold 140K. This problem is fixed in version 1.3.4.3.

Crash on Mac OS X Leopard

Anonymous — Tue, 08 Apr 2008 04:06:40 -0000

Tried launching the Apple Commander Mac OS X specific file. This does not launch on Intel Macs at all, notably the app is set to type PPC. Launching on a PPC machine brings the app up, but if you click anywhere on the app it crashes:

Exception Type: EXC_BAD_ACCESS (SIGSEGV)
Exception Codes: KERN_INVALID_ADDRESS at 0x000000007a587a58
Crashed Thread: 0

Thread 0 Crashed:
0 com.apple.QD 0x9000699c IsValidPixPatHandle + 64
1 com.apple.QD 0x900067ec SetPortPat + 88
2 com.apple.HIToolbox 0x95139ea0 SetColorAndPenState(ColorPenState*) + 92
3 com.apple.HIToolbox 0x951db174 HIIconView::DrawSelf(short, __HIShape const*, CGContext*) + 992
4 com.apple.HIToolbox 0x950f3e58 HIView::DrawCacheOrSelf(short, __HIShape const*, CGContext*) + 128
5 com.apple.HIToolbox 0x950df8d4 HIView::EventHandler(OpaqueEventHandlerCallRef*, OpaqueEventRef*, void*) + 6276
6 com.apple.HIToolbox 0x950cff68 DispatchEventToHandlers(EventTargetRec*, OpaqueEventRef*, HandlerCallRec*) + 1484
7 com.apple.HIToolbox 0x950cf100 SendEventToEventTargetInternal(OpaqueEventRef*, OpaqueEventTargetRef*, HandlerCallRec*) + 464
8 com.apple.HIToolbox 0x95143030 CallNextEventHandler + 116
9 libswt-pi-carbon-3139.jnilib 0x0e484000 Java_org_eclipse_swt_internal_carbon_OS_CallNextEventHandler + 52

Does not ask "do you wish to save ?" after DSK changed

OZ_Rhett — Wed, 24 Mar 2004 05:31:43 -0000

Start AppleCommander

Open a DSK image file

Import a file or several files

Close the AppleCommander window (back to the
starting dialog box)

There should be a "Do you want to save this disk
(Y/N) ?" type of question since the contents have
changed.

Otherwise, for newbies like me, you can easily be
flicking through disks without realising that you forgot
to save your changes ... and then you do it all over
again !!!

I've been caught out several times already.

I suspect the same problem would occur if you deleted
a file or changed its attributes.

Import of binary file does not set address in file header

Robert Greene — Sat, 31 Jan 2004 22:23:32 -0000

Import of binary file does not set address in file header.

SWT GUI does not work on Mac OS X

Robert Greene — Fri, 30 Jan 2004 03:49:45 -0000

having a problem getting AppleCommander to work in OS
X. Have
downloaded SWT 2 and 3, AppleCommander vs 1.2.3,
1.3.0 and 1.3.1 - all
exhibit the same problem - the window opens, but can't
be brought to
the front to use (it can be closed and moved in the
background). I'm
using OS X v 10.3.2, have tried with two different users
on my machine
(admin and non-admin, with some and with no startup
items
respectively). Have tried logging out and in again,
restarting as well.

I ran the jar from the commandline using the instructions
here:
http://docs.info.apple.com/article.html?
artnum=25408&sessionID=anonymous%
7C36890621&kbhost=kbase.info.apple.com%
3a80%2f#faq5

tried it with 1.3.1 and 1.4.1 for java version - was able
to get a
directory listing of a disk image at the command line, but
not to get
the GUi working.

Any ideas would be very much appreciated.

Regards

Bad data can crash AppleCommander

Robert Greene — Sun, 01 Dec 2002 02:18:18 -0000

If a disk is mostly in a known format, but has bad data
and what-not, AppleCommander may crash.
Technically, the worst culprit is a retrieving a non-
existant block or track/sector.

Improve column sort

Robert Greene — Sat, 23 Nov 2002 17:52:24 -0000

Sort can be made more efficient and more correct - use
method names for sort information instead of grabbing
an array of Strings that are computed each time and
then discarded. This also will allow sorting by actual
datatype instead of converted datatype.