Recent changes to bugs

Check for updates not working

John Hartley — Mon, 20 Apr 2009 03:59:18 -0000

The web page "http://argumentative.sourceforge.net/arg_resource/version.php?version=0.5.52" displays "Your version Argumentative () is out of date". The version number should appear in the parentheses.

A click on a graphical view element no longer shows details

John Hartley — Mon, 06 Apr 2009 23:46:24 -0000

This is a regression.
If you click on an element in the graphical view, the status line should show the element details. The Drag and Drop code which starts with a mouse down event is intercepting the click event which displays the details.

A great deal of flicker on redraw

John Hartley — Mon, 06 Apr 2009 01:55:29 -0000

This is particularly the case when moving elements. It makes the software almost unusable for large maps.

Moving elements does not count as modification

John Hartley — Thu, 02 Apr 2009 00:58:11 -0000

To reproduce:
* Open an existing argument map
* Move an element
* Close Argumentative
An offer to save the argument map does not appear

Gendarme: UseCorrectPrefixRule

John Hartley — Wed, 25 Mar 2009 03:30:27 -0000

Problem:

This type starts with an incorrect prefix or does not start with the required one. All interface names should start with the 'I' letter, followed by another capital letter. All other type names should not have any specific prefix.
Found in:

Target: Argumentative.Icommand
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: Critical Confidence: High
Details: The 'Icommand' interface name doesn't have the required 'I' prefix. Acoording to existing naming conventions, all interface names should begin with the 'I' letter followed by another capital letter.

Solution: Rename the type to have the correct prefix.

Gendarme: TypesWithDisposableFieldsShouldBeDisposableRule

John Hartley — Wed, 25 Mar 2009 03:28:27 -0000

Problem:

This type contains disposable field(s) but doesn't implement IDisposable.
Found in:

Target: Argumentative.ArgMapInterface
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Windows.Forms.TreeView Argumentative.ArgMapInterface::theTV
Details: Field implement IDisposable. Type should implement a Dispose() method

Severity: High Confidence: High
Location: System.Windows.Forms.RichTextBox Argumentative.ArgMapInterface::editArea
Details: Field implement IDisposable. Type should implement a Dispose() method

Severity: High Confidence: High
Location: System.Drawing.Printing.PrintDocument Argumentative.ArgMapInterface::pd
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.treeKeyPressCommand
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Windows.Forms.RichTextBox Argumentative.treeKeyPressCommand::richTextBox1
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.CutAndPaste
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Windows.Forms.TreeView Argumentative.CutAndPaste::tv
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.DrawTree
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Drawing.Graphics Argumentative.DrawTree::graphics
Details: Field implement IDisposable. Type should implement a Dispose() method

Severity: High Confidence: High
Location: System.Drawing.Font Argumentative.DrawTree::drawFont
Details: Field implement IDisposable. Type should implement a Dispose() method

Severity: High Confidence: High
Location: System.Drawing.Font Argumentative.DrawTree::drawFontSmall
Details: Field implement IDisposable. Type should implement a Dispose() method

Severity: High Confidence: High
Location: System.Drawing.SolidBrush Argumentative.DrawTree::drawBrush
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.FindSpec
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Windows.Forms.TreeView Argumentative.FindSpec::tv
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.Options/ElementOptions
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Drawing.Font Argumentative.Options/ElementOptions::font
Details: Field implement IDisposable. Type should implement a Dispose() method

Severity: High Confidence: High
Location: System.Drawing.SolidBrush Argumentative.Options/ElementOptions::fontBrush
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.Options/OptionsData
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Drawing.Font Argumentative.Options/OptionsData::treeFont
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.PrintTree
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Drawing.Font Argumentative.PrintTree::printFont
Details: Field implement IDisposable. Type should implement a Dispose() method

Severity: High Confidence: High
Location: System.Drawing.Printing.PrintDocument Argumentative.PrintTree::pd
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.Rationale
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.IO.StreamWriter Argumentative.Rationale::sr
Details: Field implement IDisposable. Type should implement a Dispose() method

Severity: High Confidence: High
Location: System.IO.StreamReader Argumentative.Rationale::infile
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.RTF
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Drawing.Font Argumentative.RTF::Font
Details: Field implement IDisposable. Type should implement a Dispose() method

Target: Argumentative.Tokeniser
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.IO.StreamReader Argumentative.Tokeniser::file
Details: Field implement IDisposable. Type should implement a Dispose() method
Solution:

Implement IDisposable and free the disposable field(s) in its Dispose method.

Gendarme: MarkAssemblyWithCLSCompliantRule

John Hartley — Wed, 25 Mar 2009 03:26:59 -0000

Problem:

This assembly is not decorated with the [CLSCompliant] attribute.
Found in:

Target: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: Total
Solution:

Add this attribute to ease the use (or non-use) of your assembly by CLS consumers.

Gendarme: AvoidVisibleConstantFieldRule

John Hartley — Wed, 25 Mar 2009 03:26:02 -0000

Problem:

This type contains visible field constants where the value will be embedded into the assemblies that use it.
Found in:

Target: Argumentative.Argument
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.String Argumentative.Argument::UndefinedFile
Details: 'UndefinedFile' of type System.String.

Severity: High Confidence: High
Location: System.String Argumentative.Argument::saveFilter
Details: 'saveFilter' of type System.String.

Target: Argumentative.DrawTree
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null

Severity: High Confidence: High
Location: System.Single Argumentative.DrawTree::margin
Details: 'margin' of type System.Single.
Solution:

Use a 'static readonly' field (C# syntax) to make sure a reference to the field itself is kept and avoid recompiling all assemblies.

Gendarme: AvoidLargeClassesRule

John Hartley — Wed, 25 Mar 2009 03:23:03 -0000

Problem:

The class is trying to do too much. Generally if a class is too large, duplicated code will not be far away.
Found in:

Target: Argumentative.DrawTree
Assembly: Argumentative, Version=0.5.3362.14775, Culture=neutral, PublicKeyToken=null