build on clang and fix scary looking bugs

alistra — Thu, 29 Dec 2011 13:23:54 -0000

Attaching the build.log from emerge using clang.

You should care about this, because it found some scary bugs like:

DataOutputStream.cxx:154:22: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand]
out.write((v ) && 0xff);
^ ~~~~
DataOutputStream.cxx:154:22: note: use '&' for a bitwise operation
out.write((v ) && 0xff);
^~
&
DataOutputStream.cxx:154:22: note: remove constant to silence this warning
out.write((v ) && 0xff);
^~~~~~~

or:
BigInteger.cxx:263:41: warning: shift count >= width of type [-Wshift-count-overflow]
return (jlong) (sign * ((data[size-2] << 32) + data[size-1]));

Recent changes to 4: build on clang and fix scary looking bugs

build on clang and fix scary looking bugs