Recent changes to bugs

Bitstring error

2022-06-16T14:49:31.856000Z

while setting a byte array of size 8 bits it encode succefully but while i am decoding same record it says out of bound in same bit string field

Unable to compile ASN.1 Specification of ILL APDUs

2012-11-22T14:31:07Z

./bncompiler.sh -m java -f ./ill9702.asn
BinaryNotes compiler v1.5.3
(c) 2006-2011 Abdulla G. Abdurakhmanov
Current directory: /home/rustam/tmp/jz
Compiling file: ./ill.asn
line 10:1: unexpected token: ILL-Request
line 11:1: unexpected token: Forward-Notification
line 12:1: unexpected token: Shipped
line 13:1: unexpected token: ILL-Answer
line 14:1: unexpected token: Conditional-Reply
line 15:1: unexpected token: Cancel
line 16:1: unexpected token: Cancel-Reply
line 17:1: unexpected token: Received
line 18:1: unexpected token: Recall
line 19:1: unexpected token: Returned
line 20:1: unexpected token: Checked-In
line 21:1: unexpected token: Overdue
line 22:1: unexpected token: Renew
line 23:1: unexpected token: Renew-Answer
line 24:1: unexpected token: Lost
line 25:1: unexpected token: Damaged
line 26:1: unexpected token: Message
line 27:1: unexpected token: Status-Query
line 28:1: unexpected token: Status-Or-Error-Report
line 29:1: unexpected token: Expired
line 730:9: unexpected token: GeneralString
line 733:9: unexpected token: EDIFACTString
line 1155:305: unexpected char: '%'

Encode NULL fields (BER format)

2010-08-19T09:05:04Z

Probably there no necessity to encode NULL fields. I've changed BEREncoder method encodeNull
It works fine for me.

public int encodeNull(Object object, OutputStream stream, ElementInfo elementInfo) throws Exception {
int resultSize = 0;
return resultSize;
}

DecodeSequenceOf (BER format)

2010-08-19T08:54:04Z

I've encountered such problem. When we have a structure SEQUENCE OF and its length is 128 Decoder can not decode properly.
I've found this in documentation on BER format.

There are two ways of encoding lengths - the definite form, and the indefinite form.
For the definite form, if the length is less than 128, you just use a single byte, with the high bit set to zero. Otherwise the high bit is set to one, and the low seven bits set to the length of length. The length is then encoded in that many bytes.
The indefinite form is encoded by sending a length field with a length of length of 0 - i.e. [1000|0000]. The object is ended by sending two zero bytes.

So if we have The indefinite form we don't know element's length, we should calculate it by finding a final two zero bytes.

DecodeSequence, DecodeSet methods (BER format)

2010-08-19T08:38:20Z

When we have to decode SEQUENCE or SET and there are fields with NULL values in the end of sequence (pic.1) we have problem with calculation of length of all structure. If we have NULL values in the beginning or in the middle of sequence - it OK (pic.2).

Class is set to UNIVERSAL compilation error

2010-08-19T07:47:07Z

If Class is set to Universal, e.g. [UNIVERSAL 16]

CdrRecord ::= [PRIVATE 1] SEQUENCE
{
f1 [PRIVATE 70] Type1 OPTIONAL,
f2 [UNIVERSAL 16] Type2 OPTIONAL
}

After compilation of such structure we get
@ASN1Element ( name = "f2", isOptional = true , hasTag = true, tag = 16,
tagClass = TagClass.ContextSpecific, hasDefaultValue = false )
But we should get
@ASN1Element ( name = "f2", isOptional = true , hasTag = true, tag = 16,
tagClass = TagClass.Universal , hasDefaultValue = false )

This problem can be easily fixed in
modules/java/includes/tagClass.xsl
by adding a row
<xsl:when test="tag/clazz = 'UNIVERSAL'"> TagClass.Universal </xsl:when>

<xsl:template name="tagClass">
tagClass = <xsl:choose>
<xsl:when test="tag/clazz = 'APPLICATION'"> TagClass.Application </xsl:when>
<xsl:when test="tag/clazz = 'PRIVATE'"> TagClass.Private </xsl:when>
<xsl:when test="tag/clazz = 'UNIVERSAL'"> TagClass.Universal </xsl:when>
<xsl:otherwise>TagClass.ContextSpecific</xsl:otherwise>
</xsl:choose>
</xsl:template>

Java Constructor with type Long Paramater

2009-12-02T18:30:59Z

Example:

Generated Class FooA has constructor FooA( Long someLongValue )

Class FooB calls FooA constructor

Expected Result:

new FooA( 0L )

Actual Behaviour:

new FooA( 0 ) (Zero is seen as int not long)

Invalid size count

2009-09-01T22:56:36Z

Problem:
ASN.1 notation

TestModule DEFINITIONS EXPLICIT TAGS::=
BEGIN
AttributeType ::= OBJECT IDENTIFIER
AttributeValue ::= PrintableString
Attribute ::= SEQUENCE {
type AttributeType,
values SET OF AttributeValue
}
SubjectDirectoryAttributes ::= SEQUENCE SIZE (1..MAX) OF Attribute
END

gives error "size is incorrect".

I inspected code and found problems in size tracking of tags, for example BERDecoder.java line 449
in my opinion must look like
return new DecodedObject<Object>((new ObjectIdentifier(dottedDecimal)), len.getValue());
an in source without len
return new DecodedObject<Object>((new ObjectIdentifier(dottedDecimal)));

But this fix dosen't fixed framework.

ASN.1 NULL problems

2009-08-24T21:18:13Z

There are some issues considering the ASN.1 NULL encoding:
1.Generated class doesn't have setter/getter methods.
2.Optional clause is not respected, value is always encoded.
3.“05 00”H encoding is always. Implicit and long tags are not considered.

TestNull ::= SEQUENCE
{
boolValue BOOLEAN,
nullVall [33] NULL OPTIONAL
}

Wrong encoding of BitString (using PER/U-encoding)

2009-08-05T10:21:14Z

When encoding BitString using PER/U-encoding, the last byte is encoded wrong if trailBitsCnt != 0. Instead of encoding the bits that should be included, only the trailBits are encoded.
It can be fixed by fixing the for loop in org.bn.coders.per.PerAlignedEncoder encodeBitString(...). Add "8-" before "str.getTrailBitsCnt()". The fixed for-loop should read:

for (int i = 0; i < 8-str.getTrailBitsCnt(); i++) {
int bitValue = (buffer[buffer.length - 1] >> (7 - i)) & 0x1;
bitStream.writeBit(bitValue);
}