Recent changes to bugs

Incorrect parsing of integer and enum switches

2007-12-04T07:20:22Z

Parsing

program.exe -n 1 -m 2

where n and m are integer switches fails. To solve this replace the line

this.valuePattern = @")((?<value>.+))";

with

this.valuePattern = @")((?<value>\S+))";

in IntSwitch.initialise()

The same goes for enum switches. The solution here is to replace

this.valuePattern = @")((?:"")(?<value>.+)(?:"")|(?<value>\S+))";

with

this.valuePattern = @")((?:"")(?<value>[^""]+)(?:"")|(?<value>\S+))";

in EnumSwitch.initialise()

Incorrect parsing of multiple string switches

2007-12-01T12:01:39Z

When trying to parse

app.exe -a "aaa" -b "bbb"

the value of switch a becomes

aaa" -b "bbb

This is caused by an incorrect regex in the function initialise in class StringSwitch. The line

this.valuePattern = @")((?:"")(?<value>.+)(?:"")|(?<value>\S+))";

should be replaced with

this.valuePattern = @")((?:"")(?<value>[^""]+)(?:"")|(?<value>\S+))";

Suggestions for .NET 2.0 version

2007-10-08T12:36:34Z

Some suggestions for the a .NET 2.0 version:

public static T GetOptions<T>() where T : new()
{
return GetOptions<T>(System.Environment.CommandLine);
}

public static T GetOptions<T>(string commandLine) where T : new()
{
return GetOptions<T>(commandLine, true);
}

public static T GetOptions<T>(string commandLine, bool includesProgramName) where T : new()
{
T result = new T();

CommandLineParser parser = new CommandLineParser(result);
parser.Parse(commandLine, includesProgramName);

return result;
}

public static string GetCommandLine()
{
return System.Environment.CommandLine;
}

public static string GetUsage<T>() where T : new()
{
T result = new T();

CommandLineParser parser = new CommandLineParser(result);
parser.Parse(System.Environment.CommandLine, true);

return parser.Usage;
}

public static string GetExplicitOptions<T>() where T : new()
{
T result = new T();

CommandLineParser parser = new CommandLineParser(result);
parser.Parse(System.Environment.CommandLine, true);

return parser.ExplicitOptions;
}

Incorrect constructor Parse

2007-10-08T12:35:49Z

The constructor public void Parse(string[] args) does not take into account arguments containing spaces. A more correct solution is:

public void Parse(string[] args)
{
string commandLine = "";
foreach (string arg in args)
{
if (commandLine.Length > 0)
{
commandLine += " ";
}
if (!String.IsNullOrEmpty(arg) && arg.Contains(" "))
{
commandLine += "\"" + arg + "\"";
}
else
{
commandLine += arg;
}
}

Probably this leads to problems

Incorrect parsing of commandline

2007-10-08T12:30:29Z

Commandlines like

"C:\path with space\program.exe" -k "text with space"

are parsed incorrectly.

The crulpit is in CommandLineParser.trimOffApplicationName. Changing the regex from

@"^(?<commandLine>("".+""|(\S)+))(?<remainder>.+)"

@"^(?<commandLine>(""(^"")+""|(\S)+))(?<remainder>.+)"

solves this problem.