Recent changes to bugs

#167 SpaceAfterIf rule generates false warning when if is the first statement in a Spock feature method

Chris Mair — Sat, 10 Sep 2016 23:56:45 -0000

status: open --> closed
assigned_to: Chris Mair
Group: -->

#167 SpaceAfterIf rule generates false warning when if is the first statement in a Spock feature method

Chris Mair — Sat, 10 Sep 2016 23:56:14 -0000

I'm going to go ahead and close this. If anyone reproduces this with CodeNarc 0.25 or later, please reopen.

#168 MDTM handler support

Martin Junker — Tue, 12 Jul 2016 07:34:47 -0000

ahhhh sorry wrong project, sorry. could someone move it to https://sourceforge.net/projects/mockftpserver/

MDTM handler support

Martin Junker — Tue, 12 Jul 2016 07:33:29 -0000

Hi Chris,
I wanna ask if it's possible to integrate a MDTM (https://tools.ietf.org/html/rfc3659#section-3) Handler. I've added an untested hacky Idea. 211 is not the ReplyCode (I think there is no) and return String is not defined. Please tell me what you think about.

best regards
Martin

public class MdtmCommandHandler extends AbstractFakeCommandHandler {
        private SimpleDateFormat simpleDateFormat = new SimpleDateFormat("YYYYMMDDhhmmss");

        @Override
        protected void handle(Command command, Session session) {
            verifyLoggedIn(session);

            String path = getRealPath(session, command.getRequiredParameter(0));
            String parent = getFileSystem().getParent(path);

            this.replyCodeForFileSystemException = ReplyCodes.READ_FILE_ERROR;
            verifyFileSystemCondition(getFileSystem().exists(parent), parent, "filesystem.doesNotExist");

            // User must have read permission to the parent directory
            verifyReadPermission(session, parent);

            Date lastModified = getFileSystem().getEntry(path).getLastModified();
            String result = simpleDateFormat.format(lastModified);

            sendReply(session, 211, list(result));
        }
    }

#167 SpaceAfterIf rule generates false warning when if is the first statement in a Spock feature method

Chris Mair — Sun, 03 Jul 2016 14:57:09 -0000

I was not able to reproduce with the current CodeNarc codebase (0.25.x) with either Groovy 2.1.8 or 2.4.4. There were significant Groovy-related changes in the more recent versions of CodeNarc, specifically version 0.23. I expect that upgrading CodeNarc may fix this problem.

#167 SpaceAfterIf rule generates false warning when if is the first statement in a Spock feature method

Chris Mair — Thu, 30 Jun 2016 21:06:01 -0000

For what it's worth, that is an error message, rather than a rule violation, so that means CodeNarc experienced an error parsing the source code. I'll take a look when I get a chance.

SpaceAfterIf rule generates false warning when if is the first statement in a Spock feature method

Keith Wagner — Thu, 30 Jun 2016 12:34:27 -0000

The SpaceAfterIf rule generates a false warning when the first statement in a Spock feature method is an if statement. The warning message issues is:

Error from [org.codenarc.rule.formatting.SpaceAfterIfRule] processing source file [<fully-qualified-filename>]

This error message is issued even though there is a single blank space following the if. This bug was found with CodeNarc version 0.21 and Groovy version 2.4.4.

The following test case can be used to reporduce this problem:

import org.gradle.api.Project
import org.gradle.testfixtures.ProjectBuilder
import spock.lang.Specification

class CodeNarcTestSpec extends Specification {

Project project

def setup() {
    project = ProjectBuilder.builder().build()
}

def 'codeNarcTest'() {
    given:
    if (testVar == 'true') {
        println('testing')
    }

    expect:
    project.name == 'test'

    where:
    testVar << 'true'
}

}

SpaceAfterIf rule generates false warning when if is the first statement in a Spock feature method

Keith Wagner — Thu, 30 Jun 2016 12:34:27 -0000

Ticket 167 has been modified: SpaceAfterIf rule generates false warning when if is the first statement in a Spock feature method
Edited By: Chris Mair (chrismair)
Status updated: u'open' => u'closed'
Owner updated: None => u'chrismair'

#166 Codenarc Ant task skipping files it blows up analyzing

Chris Mair — Sat, 20 Jun 2015 21:41:49 -0000

Re: making the ignore vs fail behavior for parsing errors configurable. Those errors happen on a separate thread, and so failing the Ant Task on parsing errors would require a non-trivial redesign.

Is the parsing error that you encountered even valid groovy code (e.g. the backslash following the closing brace)? My original thinking was that syntax/compiler errors would end up getting caught when the code was compiled, and so I was not going to worry too much about that -- but perhaps that was too optimistic. I do acknowledge that there is some subset of parsing errors for which it would be beneficial for CodeNarc to notify/fail.

#166 Codenarc Ant task skipping files it blows up analyzing

Chris Mair — Mon, 01 Jun 2015 21:59:43 -0000

Yes, please do open an issue about the SpaceAfterClosingBraceRule error.