addPolicerEntry

Sergio Andreozzi — Sat, 14 Oct 2006 16:54:34 -0000

n dsPolicy.cc file, on void
PolicyClassifier::addPolicerEntry(int argc, const
char*const* argv) function, near the end i found it:

policerTable[policerTableSize].initialCodePt =
(int)strtod(argv[3], NULL);
//printf("Policer: %s %s \n", argv[2], argv[3]);
if (argc == 5)
policerTable[policerTableSize].downgrade1 =
(int)strtod(argv[4], NULL);
if (argc == 6)
policerTable[policerTableSize].downgrade2 =
(int)strtod(argv[5], NULL);
policerTableSize++;

,i think that it is not entirily correct, if you have
argc == 6 you need also to
do "policerTable[policerTableSize].downgrade1 =
(int)strtod(argv[4], NULL);", or
not???
i think it would be more correct like this:

policerTable[policerTableSize].initialCodePt =
(int)strtod(argv[3], NULL);
//printf("Policer: %s %s \n", argv[2], argv[3]);
if (argc == 5)
policerTable[policerTableSize].downgrade1 =
(int)strtod(argv[4], NULL);
if (argc == 6){
policerTable[policerTableSize].downgrade1 =
(int)strtod(argv[4], NULL);
policerTable[policerTableSize].downgrade2 =
(int)strtod(argv[5], NULL);
}
policerTableSize++;

or i'm wrong???

tcpTick_ value

Sergio Andreozzi — Sat, 14 Oct 2006 16:43:35 -0000

When you develop your patch the tcpTick_ in
ns-default.tcl was 0.1, but today it is 0.01 ??? it is
correct??? So i've to change this :

if (enqueued==1) {QScheduler->EnqueEvent(pkt, queue);

PacketSize_ = cmn->size();

DSCP_= codePt;

if (cmn->ptype()==PT_TCP) {

hdr_tcp *tcp=hdr_tcp::access(pkt);

stats.TCPcwnd_CP[DSCP_]=tcp->cwnd();

stats.TCPrtt_CP[DSCP_]=tcp->t_rtt();

if (stats.TCPrttFD_CP[DSCP_]!=NULL) {

if (stats.TCPrtt_CP[DSCP_]>0)

stats.TCPrttFD_CP[DSCP_]->occurency(stats.TCPrtt_CP[DSCP_]);

stats.TCPcwndFD_CP[DSCP_]->occurency(stats.TCPcwnd_CP[DSCP_]);

}

if (tcp->reason()!=0) {

stats.TCPnReTX_CP[DSCP_]++;

stats.TCPbReTX_CP[DSCP_]+=cmn->size()/1024.0;

} else stats.TCPbGoTX_CP[DSCP_]+=cmn->size()/1024.0;

}

to this