Recent changes to bugs

RemoveRecurring sohuld be much faster

kotz.wikipedia — Tue, 14 Nov 2023 13:21:58 -0000

The current implementation for RemoveRecurring() has cubic time complexity, which means it is unusable when you get to 10,000 pages or so.

Here's an alternate implementation:

public void RemoveRecurring()
        {
            HashSet<string> titles = new HashSet<string>();
            for (int i = pages.Count - 1; i >= 0; i--)
            {
                if (titles.Contains(pages[i].title))
                {
                    pages.RemoveAt(i);
                }
                else
                {
                    titles.Add(pages[i].title);
                }
            }
        }

new site object have a problem with XML

nicolas sénéchal — Mon, 08 Aug 2022 15:05:51 -0000

Hi, I am new in C# but after googling and searching here I don't find error like this.
I test my bot in local wiki.

my wiki version is :
MediaWiki 1.37.1
PHP 8.1.2 (apache2handler)
MariaDB 10.4.22-MariaDB
ICU 70.1
Elasticsearch 6.8.23

I use 3.15 version of this framework and I compile with net6.0.
I have this part of code

System.Console.WriteLine("hox");
        var botNowiki = new MyBot();
        System.Console.WriteLine("test2");
        Site enWiki = new Site("http://localhost:8080/mediaWikiTest/mediawiki-1.37.1/index.php", "WikiCodeBots ", "mySecretPassword");//bot ce connect

I have an error when I create a new site, her is the error :

hox
DotNetWikiBot 3.15
Copyright (c) Iaroslav Vassiliev, 2006-2016, GNU General Public License 2.0

test2
Connection...
Unhandled exception. System.Xml.XmlException: Data at the root level is invalid. Line 1, position 1.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String arg)
   at System.Xml.XmlTextReaderImpl.ParseRootLevelWhitespace()
   at System.Xml.XmlTextReaderImpl.ParseDocumentContent()
   at System.Xml.XmlTextReaderImpl.Read()
   at System.Xml.XmlReader.MoveToContent()
   at System.Xml.Linq.XElement.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XElement.Parse(String text, LoadOptions options)
   at DotNetWikiBot.Site.LogIn()
   at DotNetWikiBot.Site.Initialize()
   at DotNetWikiBot.Site..ctor(String address, String userName, String userPass)
   at MyBot.Main() in C:\Users\senechal\source\repos\ConsoleApp1\Program.cs:line 145

Sortie de C:\Users\senechal\source\repos\ConsoleApp1\bin\Debug\net6.0\ConsoleApp1.exe (processus 3980). Code : 0.
Pour fermer automatiquement la console quand le débogage s'arrête, activez Outils->Options->Débogage->Fermer automatiquement la console à l'arrêt du débogage.
Appuyez sur une touche pour fermer cette fenêtre. . .

after googling I understund that it's a xml probleme, so the only xml that need the framework is DotNetWikiBot.i18n.xml so it can be oppen I don't see any error... I don"t understand... what I did wrong ?

thank you.

#117 Deprecated API calls

Sam Reed — Wed, 04 Aug 2021 23:32:31 -0000

phabricator.wikimedia.org/T280806 even.

Deprecated API calls

Sam Reed — Sat, 31 Jul 2021 16:58:33 -0000

See https://phabricator.wikimedia.org/T287819

DotNetWikiBot is doing deprecated API calls that will be disabled in the near future...

NullReference Exception when comment is hidden

forger1 — Sat, 03 Nov 2018 05:56:38 -0000

In mediawiki comments and also edits can be hidden by admins. Reading an article which comment is hidden results in a NullReference Exception in LoadWithMetadata() in line: comment = revXml.Attribute("comment").Value; So revXml.Attribute("comment") should be checked for null before accessing its Value.

CSRF Tokens don't work

Luke — Thu, 13 Sep 2018 23:05:07 -0000

I'm using DotNetWikiBot to connect to a wiki that's running MediaWiki 1.31.0. It is always running into issues where I get badtoken errors while using the obtained CSRF token, such that the token is seems to be immediately invalid for the next request.

Workaround:
I've realized that the problem goes away if I update the Site.Initialize() method such that it saves cookies when it's loading the tokens.

As in, change this:
string tokensXmlSrc = GetWebPage(apiPath + ...);

To this:
string tokensXmlSrc = PostDataAndGetResults(apiPath + ..., "", true, true);

And then the tokens aren't invalid anymore.

I should note that in my usage here, my wiki is utilizing a AuthRemoteuserSessionProvider to automatically log in (meaning an action=login API call would return an "Aborted" result), and as such I've byapssed the entire LogIn() method. But that method doesn't seem to save cookies either.

#114 Bot constructor throws exception, "new Site" fails

Luke — Thu, 13 Sep 2018 22:59:53 -0000

I'm getting a similar error on version 3.15 running under .NET framework 4.5.1. Same workaround works fine.

Exception: "The underlying connection was closed: An unexpected error occurred on a send."
Inner exception: "Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host."
Inner exception: "An existing connection was forcibly closed by the remote host"

Bot constructor throws exception, "new Site" fails

Matthias Döringer — Wed, 09 May 2018 08:10:00 -0000

I used DotNetWikiBot for many years without problem.
Now I found a problem, possibly caused by migration to .NET framework V.4.7.

To trace down the error I used DotNetWikiBot.cs and debugged it.
The error occurs in call GetWebResource() at line
webResourceText = Bot.webClient.DownloadString(address);

The first time call with address="http://dotnetwikibot.sourceforge.net/info.php" works still fine.
But the second call with address="http://sourceforge.net/p/dotnetwikibot/svn/HEAD/tree/cache/CommonData.xml?format=raw"
throws a WebException which leaves the bot unusable.
The URL exists and I can open it from my browser without problem.
HRESULT of InnerException is 0x80131620
Inner message is "Error in authentication because the other side has closed the transport stream".

I can avoid this error by manually copying several files from "cache" subfolder of DotNetWikiBot's distribution folder to the "cache" subfolder of the bot's working directory, but this is only a kludge.

#113 Incorrect values concerning Page.IsRedirect() and Page.RedirectsTo()

CodeDriller — Mon, 13 Mar 2017 09:13:23 -0000

status: open --> closed-invalid

#113 Incorrect values concerning Page.IsRedirect() and Page.RedirectsTo()

CodeDriller — Sat, 25 Feb 2017 14:43:06 -0000

You are mistaken. I just checked it out, IsRedirect() does not return "true" in this situation.

// Testing code snippet, DotNetWikiBot 3.15
Site dewb = new Site("https://de.wikibooks.org");
Page p = new Page(dewb, "Linux-Kompendium:_Links");
p.Load();
p.IsRedirect();
// false is returned

What version are you using?