Recent changes to bugs

Floating points go wrong when using other locale than en_US

Anonymous — Thu, 03 Jan 2013 14:57:05 -0000

When a project requires a different locale setting than en_US the floating points that are inserted into the sheet can be of the wrong format (i.e. 0,5 instead of the required 0.5).
This can be fixed in ExcelWriterXML_Sheet by changing the following lines: (the how and why of the fix is written in the comment)

353 $data = $cell['data'];
354 $data = htmlspecialchars($data);

353 $data = $cell['data'];
354 if (is_float($data)) {
355 /* Use sprintf to prevent loss of decimal characters, since
356 * normal float -> string conversion does not always use
357 * the . as a decimal separator. %F does not take into
358 * account locale (%f does). Since sprintf uses only a
359 * precision of up to 6 decimal places by default, we
360 * explicitely provide a precision. */
361 $prec = ini_get('precision');
362 $data = sprintf("%.${prec}F", $data);
363 }
364 $data = htmlspecialchars($data);

Warning about returning a reference of 'new'

Anonymous — Fri, 27 Jul 2012 15:50:03 -0000

PHP5.3.15 generates a warning when returning a reference to a new object. Lines 168 and 200 need to be changed to replace '=&' with '='

NOT A BUG - OpenOffice issue

Anonymous — Wed, 13 Jun 2012 10:03:02 -0000

When using MergeAcross=0 tag in OpenOffice it uses the wrong index shifting cells right.
Attaching revised code to prevent this.

function mysqlQueryToTable

Anonymous — Thu, 23 Feb 2012 18:50:41 -0000

This function is incomplete in the version I downloaded. It did not allow for the database to be passed in the function call. The operational version (at least for me) is below:

/**
* Outputs a MYSQL table or list of tables to an Excel doc
* @param string $host MySQL host to connect to
* @param string $username Username to connect with
* @param string $password Password to connect with
* @param string $db Database to use
* @param mixed $table If string, out specific table. If array, each table will have it's own sheet
*/
public function mysqlQueryToTable($host,$username,$password,$query,$db){
EWXcheckDriverDB('mysql');
if (empty($host)) $this->addError('Database','HOSTNAME is empty');
if (empty($username)) $this->addError('Database','USERNAME is empty');
if (count($this->formatErrors) > 0){return false;}

$link = mysql_connect($host,$username,$password);
if (!$link) $this->addError('Database','UNABLE to connect to '.$host.'('.mysql_error().')');
if (count($this->formatErrors) > 0){return false;}

$db_selected = mysql_select_db($db, $link);

EWXmysqlGenerateByQuery($this,$link,$query);
}
}

Sheet name max length is not tested

Anonymous — Tue, 20 Dec 2011 11:47:33 -0000

The sheet name attribute must not contain more than 32 characters.
This is not tested in function addSheet function of ExcelWriterXML class.

In attach you will find a diff that adds a test and cuts off the characters that are too much.

file cannot load on Excel Mac 2004 / X / 2011

Anonymous — Thu, 27 Jan 2011 07:43:10 -0000

On Mac OS X the generated XML files cannot be opened by Excel. Excel comes up with an error message and generates a error log. That says (in german):
[code]XML-FEHLER in ExcelWorkbook-Beschreibung
GRUND: Ungültiger Wert
DATEI: Bildmengenauswertung.xml
GRUPPE: Row
TAG: Cell
ATTRIBUT: Index
WERT: 0[/code]

It means that in tag [code]cell[/code] the attribute [code]Index[/code] must not have the value [code]0[/code].

To get the generated files loaded I'am adding + 1 on the column variable which is used as the value in the [code]ss:Index[/code] attribute of the cell. (ExcelWriterXML_Sheet.php:333)

Passing values by reference has been deprecated

Anonymous — Mon, 08 Nov 2010 00:03:12 -0000

In order to update the library to use a more recent version of php, in ExcelWriterXML.php,

Change line 168:
FROM
$style =& new ExcelWriterXML_Style($id);

TO:
unset($style);
$style = new ExcelWriterXML_Style($id);

Change line 200
FROM
$sheet =& new ExcelWriterXML_Sheet($id);
TO:
unset($sheet);
$sheet = new ExcelWriterXML_Sheet($id);

documentation error

Anonymous — Tue, 27 May 2008 15:47:03 -0000

Maybe I'm wrong, but in the documentation it states:

ExcelWriterXML::overwriteFile
overwriteFile( [boolean $overwrite = true] );

I read here that it is default true,
but this value is default false.

just to let you know.