Recent changes to bugs

Mandatory checkbox

2012-08-09T14:03:28Z

At the moment, Bool and StringBool are always valid and not_empty=True has no effect. This is unfortunate because it is not possible to have a simple checkbox on a form that the user must check to comply.

url that includes ip address not working

2012-02-07T16:56:00Z

URL validator fails with url "http://65.18.195.155/cgi-ordoro/bo/start.cgi"

Current All compound validator behaves like Pipe

2011-09-24T17:51:18Z

This leads to various issues like:

>>> All(validators=[Int, Bool]).to_python('yes')
1

even though it should fail as yes is 'yes' not an Int.

Also the fact that FormEncode mixes validation and conversion is an issue in All.

>>> All(validators=[Int, Bool]).to_python('1')
1

I get 1 even though I probably wanted a True.
Currently All is an inverse Pipe with an odd name.

A proposed solution is to add a "converter" parameter to All, in the case this parameter is available the validators are applied on the original value instead of being used on the output of the previous validator and only converter is used to provide the requested output.

>>> All(validators=[Int, Bool], converter=Bool).to_python('yes')
Invalid

>>> All(validators=[Int, Bool], converter=Bool).to_python('1')
True

Compound validators are inconsistent

2011-09-14T17:43:18Z

The three compound validators—Any, All, and Pipe—process their subvalidators in reverse order depending on the direction of conversion. But Pipe reverses them for from_python, while Any and All reverse them for to_python.

Moreover, the documentation for Any claims that the “first validator/converter that validates the value will be used”, whereas (from the user’s point of view) it’s the last one.

For consistency, all compound validators should process self.vaidators in direct order for to_python.

test suite fails with python 2.7

2011-05-28T14:31:44Z

python 2.7.1
formencode head (or whatever is the name of the top of the hg tree)
nose 1.0.0

[fetchinson@fetch formencode]$ python2.7 -c "import nose; nose.run_exit( )"
......EEEE.EE.....................................F...................................................................................
======================================================================
ERROR: tests.test_htmlfill.test_inputoutput('/home/nogradi/files/python/svn/formencode-py3k.hg/tests/htmlfill_data/data-fill1.txt',)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/nose-1.0.0-py2.7.egg/nose/case.py", line 187, in runTest
self.test(*self.arg)
File "/home/nogradi/files/python/svn/formencode-py3k.hg/tests/test_htmlfill.py", line 68, in run_filename
output_xml = ET.XML(output)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1282, in XML
parser.feed(text)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1624, in feed
self._raiseerror(v)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1488, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 1, column 9

======================================================================
ERROR: tests.test_htmlfill.test_inputoutput('/home/nogradi/files/python/svn/formencode-py3k.hg/tests/htmlfill_data/data-error1.txt',)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/nose-1.0.0-py2.7.egg/nose/case.py", line 187, in runTest
self.test(*self.arg)
File "/home/nogradi/files/python/svn/formencode-py3k.hg/tests/test_htmlfill.py", line 68, in run_filename
output_xml = ET.XML(output)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1282, in XML
parser.feed(text)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1624, in feed
self._raiseerror(v)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1488, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 2, column 5

======================================================================
ERROR: tests.test_htmlfill.test_inputoutput('/home/nogradi/files/python/svn/formencode-py3k.hg/tests/htmlfill_data/data-schema1.txt',)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/nose-1.0.0-py2.7.egg/nose/case.py", line 187, in runTest
self.test(*self.arg)
File "/home/nogradi/files/python/svn/formencode-py3k.hg/tests/test_htmlfill.py", line 68, in run_filename
output_xml = ET.XML(output)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1282, in XML
parser.feed(text)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1624, in feed
self._raiseerror(v)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1488, in _raiseerror
raise err
ParseError: mismatched tag: line 8, column 2

======================================================================
ERROR: tests.test_htmlfill.test_inputoutput('/home/nogradi/files/python/svn/formencode-py3k.hg/tests/htmlfill_data/data-fill4.txt',)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/nose-1.0.0-py2.7.egg/nose/case.py", line 187, in runTest
self.test(*self.arg)
File "/home/nogradi/files/python/svn/formencode-py3k.hg/tests/test_htmlfill.py", line 68, in run_filename
output_xml = ET.XML(output)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1283, in XML
return parser.close()
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1636, in close
self._raiseerror(v)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1488, in _raiseerror
raise err
ParseError: no element found: line 13, column 0

======================================================================
ERROR: tests.test_htmlfill.test_inputoutput('/home/nogradi/files/python/svn/formencode-py3k.hg/tests/htmlfill_data/data-fill3.txt',)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/nose-1.0.0-py2.7.egg/nose/case.py", line 187, in runTest
self.test(*self.arg)
File "/home/nogradi/files/python/svn/formencode-py3k.hg/tests/test_htmlfill.py", line 68, in run_filename
output_xml = ET.XML(output)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1282, in XML
parser.feed(text)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1624, in feed
self._raiseerror(v)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1488, in _raiseerror
raise err
ParseError: mismatched tag: line 5, column 2

======================================================================
ERROR: tests.test_htmlfill.test_inputoutput('/home/nogradi/files/python/svn/formencode-py3k.hg/tests/htmlfill_data/data-fill2.txt',)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/nose-1.0.0-py2.7.egg/nose/case.py", line 187, in runTest
self.test(*self.arg)
File "/home/nogradi/files/python/svn/formencode-py3k.hg/tests/test_htmlfill.py", line 68, in run_filename
output_xml = ET.XML(output)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1282, in XML
parser.feed(text)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1624, in feed
self._raiseerror(v)
File "/usr/local/lib/python2.7/xml/etree/ElementTree.py", line 1488, in _raiseerror
raise err
ParseError: syntax error: line 1, column 54

======================================================================
FAIL: tests.test_htmlgen.test_comment
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/local/lib/python2.7/site-packages/nose-1.0.0-py2.7.egg/nose/case.py", line 187, in runTest
self.test(*self.arg)
File "/home/nogradi/files/python/svn/formencode-py3k.hg/tests/test_htmlgen.py", line 52, in test_comment
assert str(html.comment('test')) == ''
AssertionError:

----------------------------------------------------------------------
Ran 134 tests in 0.216s

FAILED (errors=6, failures=1)

IPAddress allowing bad octets

2011-05-12T17:57:37Z

The IPAddress validator is allowing IP addresses of this form: "219.080.004.150"

Schema with UnicodeString item behaves unclearly

2011-02-13T13:25:46Z

Here's an example.

# =====================
from formencode import Schema, Invalid
from formencode.validators import UnicodeString, Int
from webob import Request

class StrictSchema(Schema):
allow_extra_fields = False

class IntegerTestSchema(StrictSchema):
testfield = Int(not_empty=True)

class StringTestSchema(StrictSchema):
testfield = UnicodeString(not_empty=True)

# Testing.
# =====================
req = Request.blank('/?testfield=111')
print IntegerTestSchema.to_python(req.params)

# This raises an exception
req = Request.blank('/?testfield=111&testfield=222')
try:
IntegerTestSchema.to_python(req.params)
except Invalid as e:
print "Caught Exception: {0}".format(e)

req = Request.blank('/?testfield=aaa')
print StringTestSchema.to_python(req.params)

# This will be passed successfully (!)
# The output will be {'testfield': u"[u'aaa', u'bbb']"}
req = Request.blank('/?testfield=aaa&testfield=bbb')
print StringTestSchema.to_python(req.params)

# ========================

Please note we do not use formencode.ForEach() or formencode.Set()
here. I think this is very unclear behaviour.

This behavior happens because mixed is used here - https://bitbucket.org/ianb/formencode/src/d95237b33f3c/formencode/api.py#cl-403
For example, if we'd have an unified behaviour for all single-value validators (Int, UnicodeString, Bool etc.) we could get "[u'John', u'Mike']" result only for "/?username=[u'John', u'Mike']" request. But now, we can get the same result by the two different requests - by "/?username=[u'John', u'Mike']" and by "/? username=John&username=Mike". This shouldn't be allowed.

Original discussion has been started here - http://groups.google.com/group/pylons-discuss/browse_thread/thread/ccbfeac4c12d3a9b

requireifpresent with timeconverter

2011-01-10T10:22:08Z

if a TimeConverter field is used with RequireIfPresent and a time in format '0:0' is given the form give a missing error

hch = fe.validators.TimeConverter(use_datetime=True, use_seconds=False)
chained_validators = [
fe.validators.RequireIfPresent(present='mane_id', required='hin')
]

the problem is at row 2648 of the validator.py module

if is_required and not value_dict.get(self.required):

this row I think must be:

if is_required and value_dict.get(self.required) is None:

formencode.api.set_stdtranslation stopped working in 1.2.3

2011-01-08T23:42:35Z

I use Pylons 1.0 and in environment.py I put:
formencode.api.set_stdtranslation(domain='FormEncode', languages=['pl'])
to get Polish messages.

It worked in 1.2.2 but stopped working in 1.2.3dev and I always get English messages.
I use uwsgi for deployment if that matters.

Sorry for the duplicate, please remove the one submitted by "nobody."

formencode.api.set_stdtranslation stopped working in 1.2.3

2011-01-08T23:40:29Z

I use Pylons 1.0 and in environment.py I put:
formencode.api.set_stdtranslation(domain='FormEncode', languages=['pl'])
to get Polish messages.

It worked in 1.2.2 but stopped working in 1.2.3dev and I always get English messages.
I use uwsgi for deployment if that matters.