Recent changes to patches

estonian translation

greg — Tue, 07 Dec 2010 06:09:09 -0000

Please update Estonian translation files in FormEncode. Updated files
are attached.

htmlfill - form:iferror missing name error

Bertrand Janin — Tue, 30 Mar 2010 02:56:09 -0000

If the "name" parameter is missing from form:iferror, name is None and an exception is raised before we even reach the proper assert a couple lines below. This patch moves the assert at the right place and updates the error string.

Deprecation warnings under Python 2.6

Tres Seaver — Tue, 12 Jan 2010 20:22:38 -0000

Two modules use the deprecated Sets module, leading to a warning:

$ /home/tseaver/projects/agendaless/OSI/karlsample/eggs/FormEncode-1.0.1-py2.6.egg/formencode/foreach.py:8: \ DeprecationWarning: the sets module is deprecated
from sets import Set

The attached patch prefers the new 'set' builtin (available since Python 2.4), falling back to the import.

DateValidator bug happening only in March under Windows :)

Christoph Zwerschke — Thu, 05 Mar 2009 20:33:56 -0000

I have just stumbled over a crazy FormEncode DateValidator bug that only appears on Windows systems in March:

----------------------------------------------------

import sys
import locale
from datetime import datetime
from formencode.validators import DateValidator

locale.setlocale(locale.LC_ALL, 'german')
print "Python", sys.version
print "Platform", sys.platform
print "Encoding", locale.getlocale()[1]
print "Month", datetime.now().strftime("%B")

# Only on a German Win XP systems in March, we get
# a UnicodeDecodeError instead of an Invalid Exception
# because Win XP uses the "cp1252" encoding
# and the month March has an Umlaut in German.

d = DateValidator(today_or_after=True)
try:
d.to_python(datetime(2000, 1, 1))
except Exception, e:
print "Error", e

----------------------------------------------------

The reason is that FormEncode tries to decode the output of strftime() with utf-8, but Win XP uses cp1252. Now the month March has an umlaut in German (März), so FormEncode tries to decode the cp1252 Umlaut as utf-8, which fails with a UnicodeDecodeError.

The reason why FormEncode decodes the strftime() value is that it needs to be merged into the messages which are Unicode (see also bug #1693684 at http://sf.net/tracker2/index.php?func=detail&aid=1693684&group_id=91231&atid=596416\).

The solution is to take the encoding from the current locale setting that is used by strftime() instead of always assuming utf-8.

See attached patch.

Update of German translations

Christoph Zwerschke — Tue, 24 Feb 2009 11:06:31 -0000

Find attached an update of the German .po file (for FormEncode r3788).

FormEncode Localization Patch - Turkish

Oktay Sancak — Fri, 14 Nov 2008 19:52:49 -0000

Turkish language support patch for FormEncode messages.

i18n ja message file

kazuok — Sat, 29 Sep 2007 10:28:34 -0000

i18n message file(po and mo) for Japanese.
these files are under PSF license or FormEncode's license.

thank you.

FE 0.5 break SQLObject's Pickle Validator

Anonymous — Fri, 21 Apr 2006 10:30:37 -0000

The recent 0.5 version of FE breaks PickleValidator and
probably other validators lacking a not_empty
attribute. The following patch fixes (or works around
it) by making the check more defensively.

There's some discussion on this in the turbogears-trunk
ML: http://tinyurl.com/kwjrw

Thanks!
Alberto

FormEncode localization patch

Ian Bicking — Thu, 26 Jan 2006 20:05:18 -0000

From Dan Jacobs

Patch for Bug #1362549

Bob Tanner — Mon, 21 Nov 2005 07:22:51 -0000

Patch for Bug #1362549, #1362566