Recent changes to bugs

#6 htb.init wrong exit status

Lubomir Bulej — Tue, 20 Mar 2018 16:53:13 -0000

Please see https://github.com/lbulej/htb.init for a fixed version.

htb.init wrong exit status

Vasili Shtyk — Thu, 16 Nov 2017 17:09:59 -0000

Hi,
getting error on Debian 8 when running htb.init as a service.

htb.init even when running success has exit code = 1.
as result getting following error:

systemd[1]: htb.init.service: control process exited, code exited status=1
systemd[1]: Failed to start SYSV: script to setup HTB traffic control

After some researc found a line at the end of start/compile case:

[ "$1" = "compile" ] && echo
As understood this required only for output formatting when we have compile option provided.
If option is "start" it produces exit code = 1

As a workaround for myself I had just commented out problem line.
Please ceck script and fix the issue if possible :-)

Thanks!

Broken timecheck when TIME specified over midnight

Anonymous — Sat, 15 Jul 2006 03:11:56 -0000

Problem occurs when at least one class contains TIME
parameters ranging over midnight.
A "midnight wrap fixup" changes TIME_ABS and uses
"fixed" value as current time when processing next TIME
rule.

FAST FIX:
move line
TIME_ABS=`htb_time2abs $TIME_NOW`
inside loop for timerule, i.e. after line
END_ABS=`htb_time2abs $END_TIME`

~Vitek

pceil and prate doesn't work in TIME section

Anonymous — Tue, 05 Apr 2005 12:19:34 -0000

I noticed that it is not possible to use pceil and
prate in TIME section for example the following doesn't
work :

TIME=08:00-23:59;64Kbit/10Kb,128Kbit
TIME=00:00-07:59;128Kbit/15Kb,pceil

I managed to fix this issue by modifying timecheck
function to look like this :

if [ $TIME_ABS -ge $BEG_ABS -a $TIME_ABS -lt $END_ABS
]; then
RATESPEC=${PARAMS%%,*}; CEILSPEC=${PARAMS##*,}

RNAME=""; CNAME=""
[ "$RATESPEC" = "prate" ] && RNAME=RATE_$PARENT
[ "$RATESPEC" = "pceil" ] && RNAME=CEIL_$PARENT
if [ -n "$RNAME" ]; then
RATESPEC=${!RNAME}
fi
[ "$CEILSPEC" = "prate" ] && CNAME=RATE_$PARENT
[ "$CEILSPEC" = "pceil" ] && CNAME=CEIL_$PARENT
if [ -n "$CNAME" ]; then
CEILSPEC=${!CNAME}
fi

[ "$RATESPEC" = "$CEILSPEC" ] && CEILSPEC=""

NEW_RATE=${RATESPEC%%/*}; NEW_BURST=${RATESPEC##*/}
[ "$NEW_RATE" = "$NEW_BURST" ] && NEW_BURST=""

NEW_CEIL=${CEILSPEC%%/*}; NEW_CBURST=${CEILSPEC##*/}
[ "$NEW_CEIL" = "$NEW_CBURST" ] && NEW_CBURST=""

MATCH=1
fi

bug with PRIO_RULE support in v 0.8.5

Oleksandr Darchuk — Wed, 04 Aug 2004 11:20:47 -0000

In v 0.8.5 support for PRIO_RULE was added. But when
insert this parameter in class file it does'nt effect.
That's because of mistake in function s
htb_filter_file: regular expression that match string
before "=" in class file is " ^[a-zA-Z0-9]+". But
PRIO_RULE doesn't match it because of "_" sign. Change
part of regexp to "^[a-zA-Z0-9_]+" (add _ in brackets)
and everything works fine.

Another timecheck Problem

Deepak Singhal — Sat, 17 May 2003 08:02:15 -0000

How to create the problem :

1.) Have a class which is parent acting as parent to
some other classes also.

2.) Add the time to the parent class.

3.) run htb.init timecheck (when it changes the
values .i.e run this command at the time specfied in
time frame of the class)

4.) run tc qdisc show

This should hangs your system or atleast your network
Interface should get hanged.

Regards

Deepak Singhal

Timecheck Problem

Deepak Singhal — Sat, 17 May 2003 07:54:36 -0000

Htb.init timecheck feature has a problem.

If you a time in a policy which starts from gt to less than
ie. for e.g. 20:00-08:00 and then time frames in the
policies which starts from less to gt -- for eg. 08:00-
14:00 are ignored .

Actually after running ## midnight wrap fix within
timecheck TimeAbs value is permanently changed to
+24*60

I have made a small change in the script and it is
attached alongwith which solves the problem