Recent changes to 223: Extensible XPathAdapter

#223 Extensible XPathAdapter

Adam Afeltowicz — Mon, 20 Oct 2014 05:29:34 -0000

Hi Ronald,

as far as I know custom XPath functions cannot be defined for real browsers - that's why this ticket is FR ;). We run testscripts defined in textfiles (so they can be prepared independently to testtool development) using HtmlUnit and sometimes standard XPath functions are not sufficient to repeat whole scenario. Of course each case could be wrapped as special actions, but this seems less flexible.

#223 Extensible XPathAdapter

RBRi — Sun, 19 Oct 2014 14:57:19 -0000

Hi Adam,
sorry for the slow progress on this topic.
Thanks for the sample.
I still have a question. What is your use case for this extension. Is this something that you can do with real browsers also?

#223 Extensible XPathAdapter

Adam Afeltowicz — Mon, 13 Oct 2014 11:09:01 -0000

Hi Roland,

please let me know if you are satisfied with my answers.

#223 Extensible XPathAdapter

Adam Afeltowicz — Fri, 10 Oct 2014 12:36:29 -0000

ad 1) Please find example usage in attachment

#223 Extensible XPathAdapter

Adam Afeltowicz — Fri, 10 Oct 2014 12:15:53 -0000

Hi Ronald,

ad 2) I agree that public field isn't elegant, but I think that FunctionTable class provides sufficient api itself (no possibility for remo, so making its instance a public static final field should be enough. I didn't find a reason why this class couldn't be a "raw" singleton as it contains only information about available XPath functions in key-value manner (schematically).

#223 Extensible XPathAdapter

RBRi — Thu, 09 Oct 2014 10:43:13 -0000

Hi Adam,

did a quick lock. Two thinks:

i miss a test case that proofs the functionality; something like adding a function and check that this function works
making the funcTable_ public might not be the most elegant way to allow extensions. I would prefer some kind of api here.

#223 Extensible XPathAdapter

Adam Afeltowicz — Thu, 09 Oct 2014 07:54:40 -0000

Can anyone give a comment if this patch could be (or not) committed into main branch?

Extensible XPathAdapter

Adam Afeltowicz — Tue, 30 Sep 2014 14:22:40 -0000

It will be nice to have possibility to extend XPath with custom functions (and it can be possible after minor XPathAdapter modification).

Please find suggested patch in attachment.