Recent changes to bugs

Can't delete from "Proteins anc crystal forms" list

Karl Levik — Thu, 03 Dec 2009 10:09:57 -0000

At Diamond we got a Java exception that originated from a constraint in the database table crystal_has_uuid - it seems the application was trying to set the crystalId column to NULL, which is not allowed because of the constraint.

I've made a fix that deletes all rows in the crystal_has_uuid table associated with the crystalId before the application goes on to delete the row in the Crystal table.

I will commit the fix shortly. If this is not a problem at the ESRF and you're concerned it will break something, I can embrace the fix in an "if DLS" condition.

CrystalClass inputfield with unwanted blank characters

Patrice Brenchereau — Mon, 09 Nov 2009 14:37:03 -0000

Trim CrystalClass input field (in order to compare crystal class types without unwanted blank characters).

# components and # samples says " 0 (0)"

Karl Levik — Thu, 22 Oct 2009 12:50:36 -0000

In the list of shipments, the "# components ( # samples )" column value is "0 (0)" until the shipment status becomes "at DLS" (or "at ESRF" I suppose). This seems slightly confusing.

I suspect the problem might be in the ShippingFullDAO.java file where the LOAD_STATEMENT_MYSQL / ORA has a condition that the dewarTransportHistory.dewarStatus is a certain value.

Manually typing image number gives error

Karl Levik — Fri, 11 Sep 2009 13:25:39 -0000

For a datacollection when you click on an image, you have the option to go to the next and previous images. There is also a field where you can type in the image number. This does not work however, and gives the following error:

Error

This is the list of errors:

* Problems retrieving images.
* javax.ejb.TransactionRolledbackLocalException: findByPrimaryKey called with null argument.

Click here to return to homepage.

And the log says:
14:17:42,175 ERROR [LogInterceptor] TransactionRolledbackLocalException in method: public abstract ispyb.server.data.interfaces.ImageLocal ispyb.server.data.interfaces.ImageLocalHome.findByPrimaryKey(java.lang.Integer) throws javax.ejb.FinderException, causedBy:
java.lang.IllegalArgumentException: findByPrimaryKey called with null argument.
at org.jboss.ejb.EntityContainer.findSingleObject(EntityContainer.java:1078)
at org.jboss.ejb.EntityContainer.findLocal(EntityContainer.java:676)
at sun.reflect.GeneratedMethodAccessor133.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.jboss.invocation.Invocation.performCall(Invocation.java:359)
at org.jboss.ejb.EntityContainer$ContainerInterceptor.invokeHome(EntityContainer.java:1126)
at org.jboss.ejb.plugins.AbstractInterceptor.invokeHome(AbstractInterceptor.java:105)
at org.jboss.ejb.plugins.EntitySynchronizationInterceptor.invokeHome(EntitySynchronizationInterceptor.java:203)
at org.jboss.resource.connectionmanager.CachedConnectionInterceptor.invokeHome(CachedConnectionInterceptor.java:189)
at org.jboss.ejb.plugins.AbstractInterceptor.invokeHome(AbstractInterceptor.java:105)
at org.jboss.ejb.plugins.EntityInstanceInterceptor.invokeHome(EntityInstanceInterceptor.java:134)
at org.jboss.ejb.plugins.EntityLockInterceptor.invokeHome(EntityLockInterceptor.java:76)
at org.jboss.ejb.plugins.EntityCreationInterceptor.invokeHome(EntityCreationInterceptor.java:43)
at org.jboss.ejb.plugins.CallValidationInterceptor.invokeHome(CallValidationInterceptor.java:56)
at org.jboss.ejb.plugins.AbstractTxInterceptor.invokeNext(AbstractTxInterceptor.java:125)
at org.jboss.ejb.plugins.TxInterceptorCMT.runWithTransactions(TxInterceptorCMT.java:350)
at org.jboss.ejb.plugins.TxInterceptorCMT.invokeHome(TxInterceptorCMT.java:161)
at org.jboss.ejb.plugins.SecurityInterceptor.invokeHome(SecurityInterceptor.java:145)
at org.jboss.ejb.plugins.LogInterceptor.invokeHome(LogInterceptor.java:132)
at org.jboss.ejb.plugins.ProxyFactoryFinderInterceptor.invokeHome(ProxyFactoryFinderInterceptor.java:107)
at org.jboss.ejb.EntityContainer.internalInvokeHome(EntityContainer.java:521)
at org.jboss.ejb.Container.invoke(Container.java:975)
at org.jboss.ejb.plugins.local.BaseLocalProxyFactory.invokeHome(BaseLocalProxyFactory.java:359)
at org.jboss.ejb.plugins.local.LocalHomeProxy.invoke(LocalHomeProxy.java:133)
at $Proxy160.findByPrimaryKey(Unknown Source)
at ispyb.server.data.ejb.ImageFacadeEJB.findByPrimaryKey(ImageFacadeEJB.java:241)
at sun.reflect.GeneratedMethodAccessor1405.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:585)
at org.jboss.invocation.Invocation.performCall(Invocation.java:359)
at org.jboss.ejb.StatelessSessionContainer$ContainerInterceptor.invoke(StatelessSessionContainer.java:237)
at org.jboss.resource.connectionmanager.CachedConnectionInterceptor.invoke(CachedConnectionInterceptor.java:158)
at org.jboss.ejb.plugins.StatelessSessionInstanceInterceptor.invoke(StatelessSessionInstanceInterceptor.java:169)
at org.jboss.ejb.plugins.CallValidationInterceptor.invoke(CallValidationInterceptor.java:63)
at org.jboss.ejb.plugins.AbstractTxInterceptor.invokeNext(AbstractTxInterceptor.java:121)
at org.jboss.ejb.plugins.TxInterceptorCMT.runWithTransactions(TxInterceptorCMT.java:350)
at org.jboss.ejb.plugins.TxInterceptorCMT.invoke(TxInterceptorCMT.java:181)
at org.jboss.ejb.plugins.SecurityInterceptor.invoke(SecurityInterceptor.java:168)
at org.jboss.ejb.plugins.LogInterceptor.invoke(LogInterceptor.java:205)
at org.jboss.ejb.plugins.ProxyFactoryFinderInterceptor.invoke(ProxyFactoryFinderInterceptor.java:136)
at org.jboss.ejb.SessionContainer.internalInvoke(SessionContainer.java:648)
at org.jboss.ejb.Container.invoke(Container.java:954)
at org.jboss.ejb.plugins.local.BaseLocalProxyFactory.invoke(BaseLocalProxyFactory.java:430)
at org.jboss.ejb.plugins.local.StatelessSessionProxy.invoke(StatelessSessionProxy.java:103)
at $Proxy337.findByPrimaryKey(Unknown Source)
at ispyb.client.results.ViewResultsAction.viewJpegImage(ViewResultsAction.java:812)
[..........]

Uploading Excel spreadsheet - Samples in double

Patrice Brenchereau — Fri, 10 Jul 2009 12:40:28 -0000

Uploading and excel spreadsheet may take a while (sometimes more than 15 minutes). I have seen users that, thinking it's not working, do the upload again while the first upload wasn't finished. It causes the shipment to have the containers and samples twice... Note that if the user does a third upload (after the 2 first ones are finished), everything is fine (previous samples are deleted and final samples will be unique).

Proposed solutions:
- speedup the file upload
- put a lock (in the shipment record in the database) on the file upload but we must be careful: if the upload crashes, the lock will prevent the user from doing another file upload on this shipment (forever). Not recommended...
- put a flag (like the lock above) that just tells the user: "Warning: another upload seems to be running for that shipment and you may have samples in double. Do you want to continue?"

Error when ranking with no selected datacollections

Karl Levik — Tue, 05 May 2009 08:12:19 -0000

This is a minor bug, and I could probably fix it myself, but thought it would be better if Patrice looked at it: When no datacollections are selected and I click the Rank button, I get the error message "java.lang.ArrayIndexOutOfBoundsException: 0".

"Protein Acronym - Space Group" doublons

Patrice Brenchereau — Wed, 25 Mar 2009 16:18:31 -0000

CreateSample: eliminate "Protein Acronym - Space Group" duplicates in combobox.

Local Contact: view shipments

Patrice Brenchereau — Mon, 09 Mar 2009 14:03:15 -0000

Can't view their shipments !

undulatorGap number format exception

Patrice Brenchereau — Mon, 09 Mar 2009 13:55:28 -0000

Number format exception on undulatorGap if number > 999 ou < -999

fr.esrf.utils.pdf.PDFFormFiller class has no .java files

Karl Levik — Wed, 11 Feb 2009 15:28:49 -0000

When generating the labels for the dewars in a shipment (i.e. clicking on the printer icon), I get a PDF file which refers to the ESRF and there are also some ESRF logos and the ESRF postal address in it. I'd like to change this for Diamond, so that we can have our own logos and address in these files.

Maybe the facility name, address and logos could be parameters to PDFFormFiller class somehow?