Recent changes to 1069: JsonFormatter

#1069 JsonFormatter

Dale Anson — Thu, 05 Aug 2021 19:14:26 -0000

Actually, this looks like an oversight in Beauty, the default json formatter isn't set in the Beauty properties file like the rest of the built-in formatters, so it needs to be set manually at the moment.

#1069 JsonFormatter

Dale Anson — Thu, 05 Aug 2021 18:17:22 -0000

Oh, good idea! It shouldn't be hard to adjust the code to detect the mode and apply the appropriate formatter if one is available.

#1069 JsonFormatter

Thomas Meyer — Thu, 05 Aug 2021 16:21:28 -0000

wow! you first need to configure the plugin to use the json beautifer for json mode, to make it work... this is really a bad UX!

#1069 JsonFormatter

Thomas Meyer — Thu, 05 Aug 2021 16:12:07 -0000

maybe it's also a good idea to mention that the Beatuy plugin supports JSON formatting somewhere in the plugins description, because currently this is not "findable" by the Plugin-Manager, search for "json" brings up only JSLint plugin...

#1069 JsonFormatter

Thomas Meyer — Thu, 05 Aug 2021 15:53:03 -0000

yes. I think it should be possible to add another if to try to format the whole buffer if there's no selection

#1069 JsonFormatter

Thomas Meyer — Thu, 05 Aug 2021 15:50:23 -0000

Hi,
how to use that mode? The plugin only seems to tell me: "Error: can't beatify this buffer because I don't know how to handle this mode".

#1069 JsonFormatter

Eric Le Lay — Thu, 05 Aug 2021 15:38:37 -0000

status: open --> pending

#1069 JsonFormatter

Eric Le Lay — Sun, 16 May 2021 16:08:42 -0000

In fact the Beauty plugin already has json pretty printing.
What enhancement does your plugin provide?

#1069 JsonFormatter

Eric Le Lay — Sun, 16 May 2021 16:06:48 -0000

My bad, it's not deprecated: it's just wrong. JsonWriter will choose utf-8 encoding. ByteArrayOutputStream.toString() will use whatever your platform has for default encoding.
So, you should give JsonWriter a StringWriter to avoid this problem and the the useless encoding/decoding from bytes.

#1069 JsonFormatter

Eric Le Lay — Sun, 16 May 2021 15:57:40 -0000

textArea.setSelectedText(s, baos.toString()) is deprecated. Specify an encoding