Recent changes to feature-requests

LDAPResultSet boolean next() fix

trames — Fri, 29 Feb 2008 17:48:54 -0000

If you try to read more results than are in the LDAPResultSet, an exception is returned (PartialResultSet). I think the intention was to return "false" back to the caller to let it know there are no more results. Here is a fix:

public boolean next() throws DAOException {
try {
if(result.hasMore()) {
logger.debug("LDAPResultSet::next() - has more");
currentResult = (SearchResult) result.next();
attrs = currentResult.getAttributes();
return true;
}
else {
currentResult = null;
attrs = null;
return false;
}
}

catch(PartialResultException ex) {
currentResult = null;
attrs = null;
return false;
}
catch(NamingException ex) {
throw new DAOException(ex);
}
}

LDAPResultSet List getResultSetNames()

trames — Thu, 28 Feb 2008 21:27:01 -0000

Add this method to retrieve a List object <String> of all the field names returned by the ResultSet. Handy if you requested all fields "SELECT *"

/**
* Returns a List of all of the field names contained
* within the result set
*
* @return
* @throws DAOException
*/
public List<String> getResultSetNames() throws DAOException {

ArrayList&lt;String&gt; names = new ArrayList&lt;String&gt;\(\);

try \{

NamingEnumeration<String> en = attrs.getIDs();
while(en.hasMore()) {
String name = (String) en.next();
names.add(name);
}
}
catch (NamingException ex) {
throw new DAOException(ex);
}

return names;

}

LDAPResultSet getList(String attrName)

trames — Wed, 27 Feb 2008 18:34:23 -0000

Add this method to retrieve by name instead of number:

// getList by attribute name
public List getList(String attrName) throws DAOException {
try {
ArrayList list = new ArrayList();
Attribute attr = attrs.get(attrName);

if(attr != null){
NamingEnumeration en = attr.getAll();
while(en.hasMore()) {
String val = (String) en.next();
list.add(val);
}
}
return list;
}
catch(NamingException ex) {
throw new DAOException(ex);
}
}

Enhance WHERE clause

trames — Mon, 25 Feb 2008 22:27:20 -0000

A cool feature would be to get rid of the LDAP silly syntax and use SQL AND/OR and even IN clauses after the WHERE.

(&(objectClass=fooOrganziation)(&(&(&(orgName=?)(orgType=?))(st=?))(orgBusinessUnit=?)))

(objectClass=fooOrganization) AND (orgName=? AND orgType=? AND st=? AND orgBusinessUnit=?)

... or something like that.