Recent changes to bugs

[BUG] [Build Failed on RISC-V Board] Please consider updating autotool scripts.

TinySnow — Sat, 15 Apr 2023 09:55:18 -0000

Hello, I'm from ArchRISC-V Team, a community porting Arch Linux software to RISC-V architecture.

Description

While packaging libcddb, we found an error.

(This link is the log about building processing our lord maintained. The log is outdated, however, the issue still exists in newer version.)

The config.guess file is too old to work.
So our team gives this advice.

Advice

You can find the patch here that how we fix it.
Or just see the patch below.(in ArchLinux PKGBUILD file):

--- PKGBUILD
+++ PKGBUILD
@@ -18,6 +18,8 @@ sha256sums=('35ce0ee1741ea38def304ddfe84a958901413aa829698357f0bee5bb8f0a223b'
 prepare() {
   cd ${pkgname}-${pkgver}
   patch -Np1 -i ../switch-default-server-to-gnudb.org.patch
+  autoreconf -fiv
+  autoupdate
 }

 build() {

Please consider updating the configure script tools (Especially config.guess file). As part of our duty, we do suggest our upstreams doing this once and for all instead.

Sincerely thanks.
:)

Arch Linux RISC-V Team,

TinySnow

Fix CDDB_LOG_H header guard (was testing against CDDB_LOH_H)

Sai Nane — Mon, 10 Apr 2023 15:10:11 -0000

cddb_log.h tests CDDB_LOH_H, but defines CDDB_LOG_H. The attached patch fixes this so that both use CDDB_LOG_H.

Collision with SEARCH_ALL define under Windows

Norbert Schlia — Fri, 16 Dec 2016 19:59:01 -0000

In iinclude/cddb/cddb_conn.h there is a typedef for SEARCH_ALL. Windows defines the same in ntddchgr.h. Unfortunately this is part of media changer IOCTL interface which is required for libcddb.

The typedef should be renamed.

include/cddb/cddb_log.h:22: bad define ?

dcb — Mon, 15 Aug 2016 15:41:26 -0000

include/cddb/cddb_log.h:22:9: warning: 'CDDB_LOH_H' is used as a header guard here, followed by #define of a different macro [-Wheader-guard]

Source code is

ifndef CDDB_LOH_H

define CDDB_LOG_H

Queries from cache always return single match

SukkoPera — Thu, 22 Jan 2015 22:51:40 -0000

When a CDDB query by disc id & category is fulfilled from cache, only one match is returned, even if the same search with cache disabled would return multiple results.

This has the annoying effect that when applications first do a query that returns multiple matches and ask the user to select the match they prefer, if they don't choose the first match, when they do search again at a later time, they will get a single results that will be different from what the user had selected before.

Fails with custom categories

Android — Wed, 15 Jun 2011 15:49:28 -0000

I run my own personal freedb server (long story, don't ask) and when I set it up I wanted better categories of music since most of my collection fell into MISC.

When checking against my freedb server the searches always fail because it converts back to MISC by default. The query finds the record, grabs the category from the freedb server and then trys to pull the record from the MISC category instead. My patch will be included in the comments below.

charset tests fail

Michael Schwendt — Thu, 17 Dec 2009 21:24:33 -0000

This is with Fedora 12 on i686:

[...]
Check charset conversion (default = UTF8)...failed (result mismatch).
Check charset conversion (alternate = ISO8859-1)...failed (result mismatch).
Results for ./check_charset.sh
Failed: 2/2
FAIL: check_charset.sh

[...]

$ cddb_query -c only -D /home/qa/tmp/rpm/BUILD/libcddb-1.3.2/tests/testcache read misc 12340000
Artist: (null)
Title: (null)
Genre: misc
Year: 0
Length: 33:20 (2000 seconds)
1 tracks
[01] '(null)' (33:18)

Clearly that result is different from testdata/12340000.UTF8.txt.
Same for the alternative encoding test:

$ cddb_query -c only -D /home/qa/tmp/rpm/BUILD/libcddb-1.3.2/tests/testcache -e ISO8859-1 read misc 12340000
Artist: (null)
Title: (null)
Genre: misc
Year: 0
Length: 33:20 (2000 seconds)
1 tracks
[01] '(null)' (33:18)

cddb_query fails

Dihenydd — Fri, 20 Nov 2009 23:50:48 -0000

There seems to be an odd issue with the cddb_query program which ships with libcddb (and also shows up in Asunder).
The command `cddb_query query time tracks offsets` is only returning one entry from freedb.org for certain discs (feels like all of mine mind). To cut to the chase I think it is due to invalid characters in the disc and artist names hence null by null.
using cd-discid I can get the following disc info's and for the sake of debugging I shall add the cddb_query command I'm running (tried various -P opts).

cd-discid
c3106d0d 13 150 22001 32751 56093 69384 102095 175470 211318 241482 263689 273711 291883 301463 4207
cddb_query query 4207 13 150 22001 32751 56093 69384 102095 175470 211318 241482 263689 273711 291883 301463

should provide Classical (Classic FM Anthems) plus others, just returns cat: misc and (artist) '(null)' by null as two separate lines with only 'Number of matches: 1'

cd-discid
be0f1a0f 15 150 16068 35338 53550 64685 84310 101898 122775 142795 162003 174973 193770 206048 226655 247404 3868
cddb_query query 3868 15 150 16068 35338 53550 64685 84310 101898 122775 142795 162003 174973 193770 206048 226655 247404
Should provide No Doubt 'Return of Saturn' amongst others, it just provides 1 folk entry, followed with the line null by null.
Weirdly, change 3868 to 3846 you get the correct No Doubt album (but at 3824 secs, not 3846) Okay, there's something funny about the number 22 here. Unfortunately 22 doesn't work elsewhere! Although I'm guessing this is completely meaningless - it tickled me.

The Massive Attack 'Mezzanine' example in the help output works, but again disc times don't match.

Searching directly for the disc (cddb_query read GENRE DISCID) works when I put the correct genre in, it's just fetching the genre list in the first place.

cd_discid
500c2c07 7 150 33105 72008 91123 125315 167495 194743 3118
should be one of the Holst's The Planets, and did return both hits twice in the not so distant past, random hits though - both through Asunder, and no software updates between working and not working, merely seconds of time between tests. I can't explain.

I suspect it may have something to do with invalid characters (or sets) in the file names as all of the examples above have at least one additional entry with what I shall dubiously call 'non-English' characters.

Gentoo amd64 (most recent to this date and only just installed from new)
libcddb-1.3.2
>locales -a
C
POSIX
en_GB
en_GB.iso88591
en_GB.utf8

example app cddb_query shouldn't link against GPL code

Michal Pryc — Tue, 05 Feb 2008 22:28:30 -0000

Hello,

The example application cddb_query is linking against libcdio library.

The problem is that cddb_query is under GNU LGPL license and libcdio is under GNU GPL license.

No LGPL'd libraries should be depending on GPL'd libraries, here is the compability matrix:
http://www.gnu.org/licenses/gpl-faq.html#AllCompatibility

So in this case the release project is under "LGPLv2.1 only" and it is linked against "GPLv2 only", as the result we've got "OK if you convert to GPLv2 [7]", which means that cddb_query shouldn't use GPLv2 library.

Errors testing libcddb 1.2.1

Pierre — Sun, 13 Nov 2005 21:40:14 -0000

[...]
PASS: check_server.sh
Check charset conversion (default = UTF8)...ok.
Check charset conversion (alternate =
ISO8859-1)...failed (cddb_query failed).
Results for ./check_charset.sh
Succeeded: 1/2
Failed: 1/2
FAIL: check_charset.sh
===================
1 of 5 tests failed
===================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/tmp/libcddb-1.2.1/tests'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/tmp/libcddb-1.2.1/tests'
make: *** [check-recursive] Error 1