Recent changes to bugs

#32 Typo in the resource directory discovery

Olaf Bergmann — Wed, 27 Jan 2016 13:48:03 -0000

All right, I will put my future issues in the github instead.

Before closing this thread, I would like to provide you with a couple of typos:

libcoap does not implement the update function of the resource directory[1]. The following "POST /rd/xxx" returns a "4.05 Method Not Allowed". The registration has a lifetime of max 24 hours and the update method is used to refresh or update the registration of a node.
In case of a malformed discovery method for a unicast request, libcoap should return a "4.00 Bad Request", not "WARN discard malformed PDU"[2]
Please, change the libcoap project's URL from the examples/*.txt files directory. I got the information of this page from there.

Oscar

[1] https://tools.ietf.org/html/draft-ietf-core-resource-directory-05#section-5.3
[2] https://tools.ietf.org/html/draft-ietf-core-resource-directory-05#section-5.1

Typo in the resource directory discovery

Wed, 27 Jan 2016 10:50:09 -0000

According to the Core Resource directory draft [1]. The discovery of the registration should be done using the /.well-known/core and including a Resource Type (rt) with the value "core.rd". Like that:

GET /.well-known/core?rt=core.rd

There is a typo in the libcoap which accept the "core-rd" instead of the "core.rd" parameter. Actually, using the "core.rd" parameter gives an error:

WARN discard malformed PDU

Regards,

Oscar

[1] - https://tools.ietf.org/html/draft-ietf-core-resource-directory-05#section-5.1

#23 server responds from wrong endpoint (ipv6 address)

Olaf Bergmann — Thu, 07 Jan 2016 16:32:17 -0000

it also breaks multicast:
./coap-server -v 10 -g FF12::11
./coap-client -v 10 -m get coap://[FF12::11]/.well-known/core

however unicast works with the same server:
./coap-client -v 10 -m get coap://[::1]/.well-known/core

#31 compilation error for COAP_RESOURCES_NO_HASH on POSIX

Olaf Bergmann — Thu, 20 Aug 2015 15:28:58 -0000

status: open --> closed-rejected

compilation error for COAP_RESOURCES_NO_HASH on POSIX

Marc Emmelmann — Wed, 12 Aug 2015 09:57:52 -0000

Disabling hashing under Posix causes compilation errors / unresolved symbols in libcoap.so

Details:

If you disable hashing (via ./configure --with-shared --without-hashing) under POSIX, you will encounter two compilation errors / unresolved symbols in libcoap.so, namely

coap_resource_iterator_init

and

coap_resource_next

The implementation for both functions is unconditionally included in resource.h (lines 333 and 336). BUT, resource.c does only implement the two functions if WITH_CONTIKI is defined (see lines 68, 128, and 135).

If hashing is disabled, COAP_RESOURCES_NO_HASH is defined and net.c invoked the above mentioned functions regardless if the code is compiled with WITH_CONTIKI defined or not. This causes linking errors on Posix (non-Contiki) systems.

compilation error for COAP_RESOURCES_NO_HASH on POSIX

Marc Emmelmann — Wed, 12 Aug 2015 09:57:52 -0000

Ticket 31 has been modified: compilation error for COAP_RESOURCES_NO_HASH on POSIX
Edited By: Olaf Bergmann (obgm)
Status updated: u'open' => u'closed-rejected'

Set pre-defined conditionals for doxygen

Olaf Bergmann — Mon, 30 Mar 2015 10:19:41 -0000

From Bill Bennett:

The conditionals are confusing doxygen (on Linux). Changing Doxyfile to:
PREDEFINED = _GNU_SOURCE WITH_POSIX
helps. I think that should be done by the autotools based on CFLAGS.

#29 Memory leak in coap_delete_attr in resource.c

Olaf Bergmann — Fri, 05 Dec 2014 14:26:36 -0000

status: open --> closed-rejected

Memory leak in coap_delete_attr in resource.c

NMacs — Tue, 02 Dec 2014 14:48:51 -0000

Seams to be a bug in POSIX environment.
void
coap_delete_attr(coap_attr_t *attr) {
if (!attr)
return;
if (attr->flags & COAP_ATTR_FLAGS_RELEASE_NAME)
coap_free(attr->name.s);
if (attr->flags & COAP_ATTR_FLAGS_RELEASE_VALUE)
coap_free(attr->value.s);

ifdef POSIX

coap_free(attr);

endif

ifdef WITH_LWIP

memp_free(MEMP_COAP_RESOURCEATTR, attr);

endif

ifdef WITH_CONTIKI

/ FIXME it looks like this was never implemented /

endif

}

should be:
void
coap_delete_attr(coap_attr_t *attr) {
if (!attr)
return;
if (attr->flags & COAP_ATTR_FLAGS_RELEASE_NAME)
coap_free(attr->name.s);
if (attr->flags & COAP_ATTR_FLAGS_RELEASE_VALUE)
coap_free(attr->value.s);

ifdef WITH_POSIX

coap_free(attr);

endif

ifdef WITH_LWIP

memp_free(MEMP_COAP_RESOURCEATTR, attr);

endif

ifdef WITH_CONTIKI

/ FIXME it looks like this was never implemented /

endif

}

Memory leak in coap_delete_attr in resource.c

NMacs — Tue, 02 Dec 2014 14:48:51 -0000

Ticket 29 has been modified: Memory leak in coap_delete_attr in resource.c
Edited By: Olaf Bergmann (obgm)
Status updated: u'open' => u'closed-rejected'