Recent changes to 7: iptc-data.c:607: poor error checking ?https://sourceforge.net/p/libiptcdata/bugs/7/2016-12-22T17:13:38.083000ZRecent changes to 7: iptc-data.c:607: poor error checking ?iptc-data.c:607: poor error checking ?2016-12-22T17:13:38.083000Z2016-12-22T17:13:38.083000Zdcbhttps://sourceforge.net/u/dcb314/https://sourceforge.netc8ca8a99c40166faa1f2fa69f46968d8aebd9bfc<div class="markdown_content"><p><span>[iptc-data.c:607]</span>: (style) Checking if unsigned variable 'i' is less than zero.</p>
<p>Source code is</p>
<div class="codehilite"><pre>i = iptc_data_dataset_index (data, dataset);
if (i < 0) return -1;
</pre></div>
<p>but</p>
<div class="codehilite"><pre>unsigned int i;
</pre></div>
<p>Suggest put return value from function into local variable<br/>
of type int, then sanity check it >= 0, then write it into <br/>
local variable i.</p>
<p><span>[pyiptcdata.c:172]</span>: (style) Checking if unsigned variable 'old_ps3_len' is less than zero.</p>
<p>Probable duplicate.</p></div>