Recent changes to patches

#2 Comparison of unsigned with zero in iptc_data_remove_dataset - solution included

Ihor Dutchak — Thu, 10 Nov 2016 20:39:15 -0000

Maybe this is more like a bug, than a patch, but let just not miss it.

Comparison of unsigned with zero in iptc_data_remove_dataset - solution included

Ihor Dutchak — Thu, 10 Nov 2016 20:36:10 -0000

iptc-data.c: in function iptc_data_remove_dataset:

int
iptc_data_remove_dataset (IptcData *data, IptcDataSet *dataset)
{
    unsigned int i;
    ...
    i = iptc_data_dataset_index (data, dataset);
    if (i < 0) return -1;
            ^^^^^
    ...
}

As a result, if a dataset index is not found, and '-1' is returned, function will try to remove a dataset with index 0xFFFFFFFF.

Solution:

if ((int)i < 0) return -1;

German translation

Sylvain Le Gall — Thu, 01 Jan 2009 14:34:06 -0000

From debian bug tracker

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=510399