Recent changes to bugs

#146 in_group bad loop

Jan Kara — Thu, 11 Dec 2025 10:20:45 -0000

status: open --> closed-fixed
assigned_to: Jan Kara
Group: -->

#146 in_group bad loop

Jan Kara — Thu, 11 Dec 2025 10:20:20 -0000

Thanks for report! The bug should be fixed now.

in_group bad loop

Anonymous — Wed, 10 Dec 2025 21:31:32 -0000

In version 4.09, rquota_server we have the following loop going the wrong way

 gid_t *gidsp = gids + len;

while (gidsp > gids)
            if (*(--gids) == gid)
        return 1;

in_group bad loop

Anonymous — Wed, 10 Dec 2025 21:31:32 -0000

Ticket 146 has been modified: in_group bad loop
Edited By: Jan Kara (jkar8572)
Status updated: 'open' => 'closed-fixed'
Owner updated: None => 'jkar8572'

#145 Does not compile with GCC 14 within the OpenWrt build environment

Jan Kara — Tue, 01 Jul 2025 13:43:38 -0000

Thanks! I've fixed this in setproject.c directly. If you give me your email address, I can properly credit you in the changelog :).

Does not compile with GCC 14 within the OpenWrt build environment

W. Michael Petullo — Sat, 31 May 2025 12:38:06 -0000

Quota does not compile with GCC 14 within the OpenWrt build environment. The problem appears to be a missing #include. This patch fixes the problem:

Here is the error:

setproject.c: In function 'main':
setproject.c:144:20: error: implicit declaration of function 'basename' [-Wimplicit-function-declaration]
  144 |         progname = basename(argv[0]);
      |                    ^~~~~~~~
setproject.c:144:18: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
  144 |         progname = basename(argv[0]);
      |

This patch fixes the problem:

diff -u --recursive quota-4.10-vanilla/common.h quota-4.10/common.h
--- quota-4.10-vanilla/common.h 2024-07-25 12:36:44.000000000 -0500
+++ quota-4.10/common.h 2025-05-31 07:27:50.828544411 -0500
@@ -7,6 +7,7 @@
 #ifndef GUARD_COMMON_H
 #define GUARD_COMMON_H

+#include <libgen.h>
 #include <time.h>
 #include <stdarg.h>

#144 Build fails on musl with implicit declaration of function basename error

Jan Kara — Mon, 22 Jul 2024 15:50:54 -0000

status: open --> closed-fixed
Group: -->

#144 Build fails on musl with implicit declaration of function basename error

Jan Kara — Mon, 22 Jul 2024 15:50:33 -0000

Thanks for the patch! After some thought I think this is actually going to be the most futureproof solution. I've just fixed up quota_nld.c (and removed the change to rquota.c) in your patch.

#144 Build fails on musl with implicit declaration of function basename error

listout — Sat, 20 Jul 2024 21:39:16 -0000

Please refer: https://bugs.gentoo.org/935812

Build fails on musl with implicit declaration of function basename error

listout — Sat, 20 Jul 2024 21:38:13 -0000

Building DiskQuota on musl fails with

quota.c: In function 'main':
quota.c:322:20: error: implicit declaration of function 'basename' [-Wimplicit-function-declaration[https://gcc.gnu.org/onlinedocs/gcc-14.1.0/gcc/Warning-Options.html#index-Wimplicit-function-declaration]]
  322 |         progname = basename(argv[0]);
      |                    ^~~~~~~~
quota.c:322:18: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion[https://gcc.gnu.org/onlinedocs/gcc-14.1.0/gcc/Warning-Options.html#index-Wint-conversion]]
  322 |         progname = basename(argv[0]);
      |                  ^

It's on musl there's in only one implementation of basename, unlike glibc. According to linux man page[0] there are two implementation of basename, one is the the POSIX version which comes from libgen.h and the GNU version which comes from string.h with _GNU_SOURCE defined.

A temporary fix is to use basename from libgen.h by default (attached patch).