Fails to build with -Werror=format-security

amoog — Mon, 27 Feb 2012 18:52:19 -0000

Hi there,

Ubuntu by default enables the so called hardening flags. Your game fails to build due to -Werror=format-security:

main.c:1738:11: warning: 'gdk_pixbuf_unref' is deprecated (declared at /usr/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243): Use 'g_object_unref' instead [-Wdeprecated-declarations]
main.c:1739:11: warning: 'gdk_pixbuf_unref' is deprecated (declared at /usr/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243): Use 'g_object_unref' instead [-Wdeprecated-declarations]
main.c:1740:11: warning: 'gdk_pixbuf_unref' is deprecated (declared at /usr/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243): Use 'g_object_unref' instead [-Wdeprecated-declarations]
main.c:1757:15: warning: 'gdk_pixbuf_unref' is deprecated (declared at /usr/include/gdk-pixbuf-2.0/gdk-pixbuf/gdk-pixbuf-core.h:243): Use 'g_object_unref' instead [-Wdeprecated-declarations]
main.c: In function 'main':
main.c:2323:5: error: format not a string literal and no format arguments [-Werror=format-security]
main.c: At top level:
main.c:2145:1: warning: 'tray_popup_activate_action' defined but not used [-Wunused-function]
main.c: In function 'ui_record_score':
main.c:1932:12: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
main.c: In function 'ui_read_game_data':
main.c:1843:10: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
main.c:1844:10: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
cc1: some warnings being treated as errors

make[3]: *** [main.o] Error 1
make[3]: Leaving directory `/build/buildd/llk-linux-2.3~beta1/src'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/build/buildd/llk-linux-2.3~beta1'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/build/buildd/llk-linux-2.3~beta1'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2

https://launchpad.net/ubuntu/+archive/test-rebuild-20120201/+build/3160669/+files/buildlog_ubuntu-precise-i386.llk-linux_2.3~beta1-0ubuntu4_FAILEDTOBUILD.txt.gz

Patch attached

Package fails to compile with GCC4.5

Anonymous — Tue, 28 Dec 2010 14:13:25 -0000

Hello dear maintainer

when trying to compile with GCC 4.5 and GNU binutils-gold on latest updated ubuntu 11.04 version your package fails to compile

Refer:

http://people.ubuntuwire.org/~lucas/ubuntu-nbs/32/llk-linux_2.3~beta1-0ubuntu2_lubuntu32.buildlog

http://people.ubuntuwire.org/~lucas/ubuntu-nbs/64/llk-linux_2.3~beta1-0ubuntu2_lubuntu64.buildlog

The attached patch should fix the problem

regards

the source of .pak file

LI Daobing — Mon, 18 May 2009 12:00:28 -0000

Hello,

llk-linux is rejected by Debian because there is no source for the .pak files. (the original mail in [1]). can you provide the source of the .pak files and release a new version for this?

thanks.

[1]
Hi Maintainer,

rejected, where is the source for the .pak files in data/?
If its in side the package - im sorry, i havent found it. If not - it
must be there or it cant go into main.

--
bye Joerg

Recent changes to bugs

Fails to build with -Werror=format-security

Package fails to compile with GCC4.5

the source of .pak file