Recent changes to 15: "Find matching tag" - Slow Response

#15 "Find matching tag" - Slow Response

Yaron — Wed, 21 Jan 2015 20:19:56 -0000

Hello Martijn,

I'm glad you feel a bit better.
Life is full of ups and downs.

I liked your noble remark regarding EditPad.

Special thanks for the Feature Requests.
Please wait with them until you get much better. :)

Again, I wish you the very best.

#15 "Find matching tag" - Slow Response

Martijn Coppoolse — Wed, 21 Jan 2015 19:41:59 -0000

I’m relatively better now, thanks.

Well... I wouldn’t say EditPad has a bug; its author just made a different design decision.

I’ll put your proposals #1 and #2 on the feature request list. Putting the caret at the beginning of a matching tag does make sense; and toggling the caret between start and end of a self-closing tag does too.

#15 "Find matching tag" - Slow Response

Yaron — Wed, 21 Jan 2015 17:38:29 -0000

Hello Martijn,

I hope you are doing well.

Thanks again for your excellent work.

The entire matching tag is selected on my machine as well.

Comment #1 and Comment#2 seem to be related.
If the caret was always moved to the beginning of opening/closing tags (it makes sense), then the user would get some reaction after pressing "Find matching tag" again in the example given in Comment #1 (i.e. the caret would move to the beginning of the line).

These are really minor issues, and HTMLTag plugin works like a charm.

Comment #3:
So, the bug is in EditPad. :)

Best wishes.

#15 "Find matching tag" - Slow Response

Martijn Coppoolse — Wed, 21 Jan 2015 14:41:50 -0000

Hello Yaron,

Thanks for your comments!

On my machines, it's not just the caret that is moved; the entire matching tag is selected — that is by design. That's why the caret is always moved to the end (although I guess I could also put the caret at the start of the selection).
Is the matched tag not selected on your machine?

Also, when the caret is located in text between two tags, the plugin should find the first preceding opening tag, and then select its matching tag.

#15 "Find matching tag" - Slow Response

Yaron — Wed, 21 Jan 2015 01:36:27 -0000

Hello Martijn,

I do hope you get better soon.

And thank you so much for finding the time to fix the reported issue.
A brilliant work!

With your permission, a few comments (tested on langs.xml):
1)
Go to the line <Language name="normal" ext="txt"/>.
Position the caret on "Language".
Press "Find matching tag" (- the caret is moved to the end of the line).
Press "Find matching tag" again.
- Result: the caret isn't moved back.

2)
Position the caret on an opening tag (first "<NotepadPlus>").
Press "Find matching tag".
- Result: the caret is moved to the end of the closing tag.
Wouldn't it be better to always move the caret to the beginning of opening/closing tags?

3)
Position the caret on "getTransform" (appears once).
Press "Find matching tag".
- Result: the caret is moved to the closing "</Keywords>".
Is that the expected behavior (- rather than no action at all)?

I have compared HTMLTag plugin's behavior with that of EditPad.
http://www.editpadpro.com.

I appreciate your kindness, and truly wish you the very best.

#15 "Find matching tag" - Slow Response

Martijn Coppoolse — Tue, 20 Jan 2015 20:49:35 -0000

Yaron,

Would you try downloading the new unicode version from http://fossil.2of4.net/npp_htmltag/ and test it?

I think I've managed to fix the problem, but my life's a bit hectic atm, I'm a bit tired, and I'm not sure I haven't missed any edge cases or made some silly coding mistake.

If it's fine, I'll see about uploading the new version to the plugin manager sometime next week.

#15 "Find matching tag" - Slow Response

Yaron — Tue, 20 Jan 2015 01:46:56 -0000

Thank you Martijn.

Good luck!

#15 "Find matching tag" - Slow Response

Martijn Coppoolse — Mon, 19 Jan 2015 07:16:32 -0000

@Yaron: you won't be able to open the HTMLTag plugin with Visual Studio, because it was written in Delphi.
@Dave: thanks for the reminder that the solution needn't be all that complex. I'll try and implement it as soon as I can (it's a bit more convoluted than you suggested, due to my implementation of Find -- which returns an object that needs to be destroyed after use. This was one of my first real Delphi projects ever).

#15 "Find matching tag" - Slow Response

Yaron — Sun, 18 Jan 2015 21:14:06 -0000

Thank you Dave.

I have just recently started using VS 2013, and I can't open the HTMLTag plugin's project files in it.

I'm grateful for your help.

I hope Martijn will find the time to fix it.

Best regards.

#15 "Find matching tag" - Slow Response

Dave Brotherstone — Sun, 18 Jan 2015 09:44:03 -0000

Not much to say here, other than yes, backwards regex search with the new engine is pretty slow. It's not really built for that. Reverse regex search would be doable by reversing the actual regex, which I think would be pretty complicated, at least if you expected the same results. The internal tag matching routine basically emulates the tiny amount of regex that is needed using a simple search. So in your example,

NextTag := doc.Find('[^%\?]>', SCFIND_REGEXP or SCFIND_POSIX, Tag.StartPos, 0);

We'd just change that to (excuse syntax, but you get the idea)

Do
    NextTag := doc.Find('>', 0, Tag.StartPos, 0);
While(NextTag != -1 And (doc.CharAt(nextTag-1) == '%' Or doc.CharAt(nextTag-1) == '?'))

Dave