Recent changes to bugs

#46 concurrent compiles sometimes fails

Jaco Kroon — Tue, 20 Sep 2016 13:28:13 -0000

Additionally the pattern %.o : %.c really should get | generated-files appended as an additional dependency as well (line 274).

concurrent compiles sometimes fails

Jaco Kroon — Tue, 20 Sep 2016 13:24:04 -0000

On line 214 of the Makefile:

l2tp_config_token.o should depend on l2tp_config_parse.h

incorrect-fsf-address

StrPt — Wed, 08 Oct 2014 12:29:18 -0000

openl2tp-devel.i586: W: incorrect-fsf-address /usr/lib/openl2tp/l2tp_rpc.x

openl2tpd: page allocation failure

jacquesqiao — Thu, 11 Jul 2013 03:16:13 -0000

I use openl2tp on openwrt as a l2tp client. When i connect to a l2tp server I set up with xl2tp,it works very well. But when i connect to a cisco 7206 l2tp server. After CHAP authentication succeeded, the kernel warn :pppd: page allocation failure: order:7, mode:0x4020
the log was:

pppd[3291]: rcvd [CHAP Success id=0x1 ""]
daemon.info pppd[3291]: CHAP authentication succeeded
daemon.notice pppd[3291]: CHAP authentication succeeded
daemon.debug pppd[3291]: sent [IPCP ConfReq id=0x1 ]
daemon.debug pppd[3291]: rcvd [IPCP ConfReq id=0x1 ]
daemon.debug pppd[3291]: sent [IPCP ConfAck id=0x1 ]
daemon.debug pppd[3291]: rcvd [IPCP ConfNak id=0x1 ]
daemon.debug pppd[3291]: sent [IPCP ConfReq id=0x2 ]
daemon.debug pppd[3291]: rcvd [IPCP ConfAck id=0x2 ]
daemon.err pppd[3291]: not replacing existing default route via 192.168.5.253
daemon.notice pppd[3291]: local IP address 10.0.0.2
daemon.notice pppd[3291]: remote IP address 61.154.237.10
daemon.debug pppd[3291]: openl2tp send: sent PPP_UPDOWN_IND, 52 bytes
daemon.debug pppd[3291]: Script /etc/ppp/ip-up started (pid 3453)
kern.warn kernel: [55094.050000] pppd: page allocation failure: order:7, mode:0x4020
Hiwifi kern.warn kernel: [55094.060000] Call Trace:
daemon.debug pppd[3291]: Script /etc/ppp/ip-up finished (pid 3453), status = 0x1
Hiwifi kern.warn kernel: [55094.060000] [<80269d14>] dump_stack+0x8/0x34
kern.warn kernel: [55094.060000] [<800af668>] warn_alloc_failed+0xe8/0x10c
kern.warn kernel: [55094.070000] [<800b1968>] alloc_pages_nodemask+0x5a0/0x600
kern.warn kernel: [55094.080000] [<800b19e0>] get_free_pages+0x18/0x4c
kern.warn kernel: [55094.080000] [<801dae24>] pskb_expand_head+0xf8/0x2d4
kern.warn kernel: [55094.090000] [<83395298>] 0x83395298
kern.warn kernel: [55094.090000]

there are some other people also find this problem.
https://dev.openwrt.org/ticket/12011#comment:11>
we guess that there are some problems in the kernel module because when user xl2tp this also happen, can you help me about this or give me some guide to find the reason?
much thanks

ppp segfaults when ippool plugin is used

timeos — Fri, 18 Jan 2013 14:24:21 -0000

ppp segfaults when
- ippool.so plugin must be is used within ppp option file, AND
- "dump" directive is present also within ppp option file

after initiating IPSec/L2TP connection by Windows client to linux VPN server and after ppp process started by L2TP daemon, pppd crashed with following details:
pppd[31761]: segfault at 0 ip 00007ff71d770858 sp 00007fff04db57a0 error 4 in pppd[7ff71d748000+52000]
------------[ cut here ]------------
WARNING: at include/net/sock.h:472 udp_lib_unhash+0xbf/0xd0() (Tainted: G W ---------------- )
Modules linked in: pppol2tp ppp_deflate pppoe pppox ppp_async crc_ccitt authenc esp4 xfrm4_mode_transport arc4 ppp_mppe_mppc nf_conntrack_netlink nfnetlink ip_vs ppp_generic slhc deflate zlib_deflate ctr twofish_x86_64 twofish_common camellia serpent blowfish cast5 des_generic cbc cryptd aes_x86_64 aes_generic xcbc rmd160 sha256_generic tun crypto_null af_key xenfs iptable_mangle iptable_nat nf_nat xt_pkttype nf_conntrack_ipv4 nf_defrag_ipv4 iptable_filter ip_tables xt_MARK ip6table_mangle xt_limit xt_policy nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack xt_multiport ip6table_filter ip6_tables ipv6 xen_netfront ext4 mbcache jbd2 xen_blkfront dm_mirror dm_region_hash dm_log dm_mod [last unloaded: pppol2tp]
Pid: 31501, comm: openl2tpd Tainted: G W ---------------- 2.6.32-220.4.1.el6.mppc_saref.x86_64 #1
Call Trace:
[<ffffffff81069a17>] ? warn_slowpath_common+0x87/0xc0
[<ffffffff81069a6a>] ? warn_slowpath_null+0x1a/0x20
[<ffffffff8148a22f>] ? udp_lib_unhash+0xbf/0xd0
[<ffffffff8141e8f2>] ? sk_common_release+0x32/0xd0
[<ffffffff81488ffe>] ? udp_lib_close+0xe/0x10
[<ffffffff81493df7>] ? inet_release+0x67/0x90
[<ffffffff81418a69>] ? sock_release+0x29/0x90
[<ffffffff81418ae7>] ? sock_close+0x17/0x30
[<ffffffff81177d25>] ? __fput+0xf5/0x210
[<ffffffff81177e65>] ? fput+0x25/0x30
[<ffffffff811738ad>] ? filp_close+0x5d/0x90
[<ffffffff81173985>] ? sys_close+0xa5/0x100
[<ffffffff8100b0f2>] ? system_call_fastpath+0x16/0x1b
---[ end trace 8a3a8d1bc708fc3d ]---

Jan 18 11:49:06 vpn01 openl2tpd[19195]: checking for optionsfile
Jan 18 11:49:06 vpn01 openl2tpd[19195]: setting options=/etc/ppp/options.openl2tpd
Jan 18 11:49:06 vpn01 pppd[19195]: Plugin radius.so loaded.
Jan 18 11:49:06 vpn01 pppd[19195]: Using EAP TLS.
Jan 18 11:49:06 vpn01 pppd[19195]: RADIUS plugin initialized.
Jan 18 11:49:06 vpn01 pppd[19195]: Plugin ippool.so loaded.
Jan 18 11:49:06 vpn01 pppd[19195]: Plugin pppol2tp.so loaded.
Jan 18 11:49:06 vpn01 pppd[19195]: Plugin openl2tp.so loaded.
Jan 18 11:49:06 vpn01 pppd[19195]: pppd options in effect:
Jan 18 11:49:06 vpn01 pppd[19195]: debug # (from /etc/ppp/options.openl2tpd)
Jan 18 11:49:06 vpn01 pppd[19195]: nodetach # (from command line)
Jan 18 11:49:06 vpn01 pppd[19195]: idle 1800 # (from /etc/ppp/options.openl2tpd)
Jan 18 11:49:06 vpn01 pppd[19195]: dump # (from /etc/ppp/options.openl2tpd)
Jan 18 11:49:06 vpn01 pppd[19195]: nomp # (from command line)
Jan 18 11:49:06 vpn01 pppd[19195]: plugin radius.so # (from /etc/ppp/options.openl2tpd)
Jan 18 11:49:06 vpn01 pppd[19195]: plugin ippool.so # (from command line)
Jan 18 11:49:06 vpn01 pppd[19195]: plugin pppol2tp.so # (from command line)
Jan 18 11:49:06 vpn01 pppd[19195]: plugin openl2tp.so # (from command line)
Jan 18 11:49:06 vpn01 pppd[19195]: auth # (from command line)
Jan 18 11:49:06 vpn01 pppd[19195]: refuse-pap # (from /etc/ppp/options.openl2tpd)
Jan 18 11:49:06 vpn01 pppd[19195]: refuse-chap # (from /etc/ppp/options.openl2tpd)
Jan 18 11:49:06 vpn01 pppd[19195]: refuse-mschap # (from /etc/ppp/options.openl2tpd)
Jan 18 11:49:06 vpn01 pppd[19195]: require-eap # (from /etc/ppp/options.openl2tpd)
Jan 18 11:49:06 vpn01 pppd[19195]: name openl2tp # (from /etc/ppp/options.openl2tpd)

but in general when I comment out "dump" directive, the ppp process continue to work without problems.

so this bug is not directly related to openl2tp as I can reproduce it with xl2tpd daemon.

used versions:
ppp-2.4.5
openl2tp-1.8
ippool-1.3

Potential problem with not null-terminated strings in AVPs

Anonymous — Tue, 08 May 2012 13:48:41 -0000

There might be an issue in the method l2tp_session_store_avps (l2tp_session.c) if the AVPs are not null-terminated. We are using v1.8 and when I do a "session show" in l2tpconfig I get trailing garbage after "calling number" and "called number" on the sessions from some equipment (vendor name "StarentNetworks"). Since the AVPs have a length-information I am guessing that the Starent does not send null-terminated strings and since l2tp_session_store_avps simply uses strdup without looking at the length information the resulting strings stored in struct l2tp_session can be to long. Using strndup with the length-information should avoid this.

AVPs that are stored in struct tunnel (l2tp_tunnel_store_avps in l2tp_tunnel.c) are handled differently, for example VENDOR_NAME/HOST_NAME are always stored null-terminated

Cannot enable IPv6

David Woodhouse — Tue, 24 Apr 2012 20:52:31 -0000

This is the 21st century. Arguably '+ipv6' ought to be the default behaviour of pppd anyway; there's no excuse for not supporting IPv6, when the worst that can happen is that you get a ProtRej when you attempt to talk IPv6CP.

But it's worse than that. I don't see any way to enable IPv6 at all. I can't even pass extra options to pppd (which I want to for things like naming the interface, when invoking it from NetworkManager, on openwrt, etc.)

Unless I'm missing something...?

WARNING: at include/net/sock.h:471

Chris Tucker — Wed, 11 Jan 2012 12:07:06 -0000

CentOS 6, kernel 2.6.32-220.2.1.el6.x86_64. OpenL2TP 1.8 source, used rpmbuild and installed as openl2tp-1.8-1.el6.x86_64.

VPN from Windows XP client using L2TP over IPsec works perfectly using our_udp_port=1701 in /etc/openl2tpd.conf and 'OPENL2TPDARGS=' in /etc/sysconfig/openl2tpd.

When I remove our_udp_port=1701 from /etc/openl2tpd.conf, define OPENL2TPDARGS="-p ipsec.so" in /etc/sysconfig/openl2tpd and restart openl2tpd, client fails to connect and I get the following in syslog:

Jan 11 11:04:57 pdc-polly kernel: ------------[ cut here ]------------
Jan 11 11:04:57 pdc-polly kernel: WARNING: at include/net/sock.h:471 udp_lib_unhash+0xbf/0xd0() (Tainted: G W ---------------- )
Jan 11 11:04:57 pdc-polly kernel: Hardware name: ProLiant DL360 G7
Jan 11 11:04:57 pdc-polly kernel: Modules linked in: pppol2tp pppox iptable_filter iptable_nat nf_nat nf_conntrack_ipv4 nf_defrag_ipv4 iptable_mangle ip_tables arc4 ecb ppp_mppe authenc esp4 xfrm4_mode_transport ppp_generic slhc deflate zlib_deflate ctr twofish_x86_64 twofish_common camellia serpent blowfish cast5 des_generic cbc aesni_intel cryptd aes_x86_64 aes_generic xcbc rmd160 sha256_generic crypto_null af_key xt_policy ipt_LOG xt_multiport ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 xt_state nf_conntrack ip6table_filter ip6_tables ipv6 power_meter bnx2 sg serio_raw iTCO_wdt iTCO_vendor_support hpilo hpwdt i7core_edac edac_core shpchp ext4 mbcache jbd2 sd_mod crc_t10dif hpsa radeon ttm drm_kms_helper drm i2c_algo_bit i2c_core dm_mirror dm_region_hash dm_log dm_mod [last unloaded: pppox]
Jan 11 11:04:57 pdc-polly kernel: Pid: 23184, comm: openl2tpd Tainted: G W ---------------- 2.6.32-220.2.1.el6.x86_64 #1
Jan 11 11:04:57 pdc-polly kernel: Call Trace:
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff81069997>] ? warn_slowpath_common+0x87/0xc0
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff810699ea>] ? warn_slowpath_null+0x1a/0x20
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff81489fcf>] ? udp_lib_unhash+0xbf/0xd0
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff8141e992>] ? sk_common_release+0x32/0xd0
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff81488d9e>] ? udp_lib_close+0xe/0x10
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff81493b17>] ? inet_release+0x67/0x90
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff81418b39>] ? sock_release+0x29/0x90
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff81418bb7>] ? sock_close+0x17/0x30
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff81177ca5>] ? __fput+0xf5/0x210
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff81177de5>] ? fput+0x25/0x30
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff8117382d>] ? filp_close+0x5d/0x90
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff8106c4bf>] ? put_files_struct+0x7f/0xf0
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff8106c583>] ? exit_files+0x53/0x70
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff8106e625>] ? do_exit+0x185/0x860
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff810d4502>] ? audit_syscall_entry+0x272/0x2a0
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff8106ed58>] ? do_group_exit+0x58/0xd0
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff8106ede7>] ? sys_exit_group+0x17/0x20
Jan 11 11:04:57 pdc-polly kernel: [<ffffffff8100b0f2>] ? system_call_fastpath+0x16/0x1b
Jan 11 11:04:57 pdc-polly kernel: ---[ end trace 5b6ae84af4d6d236 ]---

ipsec plugin uses insecure temporary file

Jacek Konieczny — Sat, 26 Nov 2011 16:50:04 -0000

From plugins/ipsec.c:

#define IPSEC_SETKEY_FILE "/tmp/openl2tpd-tmp"

and later:

FILE *f = fopen(IPSEC_SETKEY_FILE, "w");

This is insecure code – any user on the local system, that can write to /tmp could create a symlink to any root-owned file and openl2tpd will overwrite the file when preparing input for 'setkey'.

The solution is to use a secure temporary file, e.g. created with mkstemp(), or write the file in a directory only root can write to (e.g. /var/run/openl2tp).

libreadline5 and libreadline6 for deb-packages

StrPt — Fri, 22 Jul 2011 11:07:58 -0000

I think that the deb-packages incorrectly compiled, the error in control, so as Ubuntu to have pre-installed libreadline6,
but the package openl2tp still requires additional install libreadline5.
libreadline5 is not required for rpm-distributions, if already installed libreadline6.