DEFAULT_LOCAL_METHOD is useless

Anonymous — Fri, 05 Mar 2010 16:32:02 -0000

The DEFAULT_LOCAL_METHOD configuration directive appears to be useless. The fopen call does not currently have any logic to open the log file with any other method than "a". Also , methods to set the local method are missing. Here is my implementation of this.

# diff php-logger_v2.inc /home/ctatechs/tmp/phplogger/php-logger/php-logger_v2.inc
355d354
< var $logfile_method;
364,365c363
< $this->local_set_logfile_name(DEFAULT_LOCAL_LOGFILE_NAME);
< $this->local_set_logfile_method(DEFAULT_LOCAL_METHOD);
---
> $this->local_set_logfile_name(DEFAULT_LOCAL_LOGFILE_NAME);
369,371c367
< function local_set_logfile_method($method) {
< $this->logfile_method=$method;
< }
---
>
376c372
<
---
>
406,408c402,403
< }
< $file_mode=$this->logfile_method=="APPEND" ? "a" : "w+";
< if ($this->file_pointer = fopen ($this->log_file, $file_mode))
---
> }
> if ($this->file_pointer = fopen ($this->log_file, "a"))

Recent changes to bugs

DEFAULT_LOCAL_METHOD is useless