Recent changes to bugs

#24 bldcat should cleanup temp dir after each package is inspected

Peter Bonivart — Fri, 17 Oct 2014 12:34:58 -0000

status: open --> closed

#24 bldcat should cleanup temp dir after each package is inspected

Peter Bonivart — Thu, 16 Oct 2014 20:07:24 -0000

assigned_to: Peter Bonivart
Group: -->
Priority: 1 --> 3

bldcat should cleanup temp dir after each package is inspected

Rob Wissmann — Wed, 15 Oct 2014 18:46:38 -0000

bldcat creates a tmp directory for unpacking packages into using the function File::Temp::tempdir with the CLEANUP flag set.

According to the File::Temp docs, CLEANUP cleans up when the program exits:

Create a temporary directory using the supplied template, but attempt to remove it (and all files inside it) when the program exits.

via http://perldoc.perl.org/File/Temp.html

Delaying cleanup of temporary directories containing expanded packages until bldcat has finished is not an ideal situation. It means that storage space required for generating a catalog is larger than the storage space required for the packages, which can become problematic when building a catalog containing a large number of packages.

I could not find a particular reason for all packages to remain expanded until bldcat completes. It looks to me as if bldcat processes packages one at a time.

To remedy the situation I placed a call to File::Temp::cleanup at the end of the main inspection loop. Docs for File::Temp::cleanup:

Calling this function will cause any temp files or temp directories that are registered for removal to be removed. This happens automatically when the process exits but can be triggered manually if the caller is sure that none of the temp files are required. This method can be registered as an Apache callback.
Note that if a temp directory is your current directory, it cannot be removed. C out of the directory first before calling C. (For the cleanup at program exit when the CLEANUP flag is set, this happens automatically.)
On OSes where temp files are automatically removed when the temp file is closed, calling this function will have no effect other than to remove temporary directories (which may include temporary files).

This call causes temporary directories to be cleaned up after each package is processed. Thus the issue of N storage space being used while building a catalog is alleviated.

Attached is a patch.

bldcat should cleanup temp dir after each package is inspected

Rob Wissmann — Wed, 15 Oct 2014 18:46:38 -0000

Ticket 24 has been modified: bldcat should cleanup temp dir after each package is inspected
Edited By: Peter Bonivart (bonivart)
_priority updated: u'1' => u'3'
Owner updated: None => u'bonivart'

bldcat should cleanup temp dir after each package is inspected

Rob Wissmann — Wed, 15 Oct 2014 18:46:38 -0000

Ticket 24 has been modified: bldcat should cleanup temp dir after each package is inspected
Edited By: Peter Bonivart (bonivart)
Status updated: u'open' => u'closed'

Support for 304 Not Modified

Maciej Bliziński — Sat, 24 May 2014 11:45:49 -0000

When run with -U, pkgutil always downloads the body of the catalog file.

Conversation started in:
http://lists.opencsw.org/pipermail/maintainers/2013-October/018763.html

One of the problems described in:
http://lists.opencsw.org/pipermail/maintainers/2013-October/018768.html

...that -O is used, and -O is incompatible with -N (timestamping) in wget.

Ticket 22 has been modified: ssh fails Edited By: Peter Bonivart (bonivart) Owner updated: None => u'bonivart'

Peter Bonivart — Sat, 22 Sep 2012 13:26:03 -0000

Ticket 22 has been modified: ssh fails Edited By: Peter Bonivart (bonivart) Owner updated: None => u'bonivart'

Ticket 22 has been modified: ssh fails Edited By: Peter Bonivart (bonivart)

Peter Bonivart — Sat, 22 Sep 2012 13:25:46 -0000

Ticket 22 has been modified: ssh fails Edited By: Peter Bonivart (bonivart)

Ticket 22 has been modified: ssh fails Edited By: Peter Bonivart (bonivart) Status updated: u'open' => u'closed'

Peter Bonivart — Sat, 22 Sep 2012 13:24:59 -0000

Ticket 22 has been modified: ssh fails Edited By: Peter Bonivart (bonivart) Status updated: u'open' => u'closed'

#22 ssh fails

Peter Bonivart — Sat, 22 Sep 2012 13:24:59 -0000

- **status**: open --> closed - **milestone**: -->