Recent changes to 72: Documenting constants in dsdpcm_constants.h

#72 Documenting constants in dsdpcm_constants.h

Pier-Luc — Tue, 11 Apr 2023 14:55:31 -0000

Great, thank you! I will take a look at that.

#72 Documenting constants in dsdpcm_constants.h

Maxim V.Anisiutkin — Sun, 09 Apr 2023 06:46:13 -0000

All FIRs except PCMFIR4_147_160_COEFS were borrowed from Philips Audio Format Converter utility. PCMFIR2_2_COEFS and PCMFIR3_2_COEFS look like usual half band filters. Regarding DSDFIR1_8/16/64_COEFS I just don't know. Al least zeros/poles plots are unfamiliar for me. I decided to leave all "AS IS" to be kind of a reference point for other developers. Actually, Philips AFC is the source of all this stuff.

Documenting constants in dsdpcm_constants.h

Pier-Luc — Sat, 08 Apr 2023 15:42:03 -0000

Hello,

In the dsdpcm_constants.h file, the constants defined in there are not documented. Is there any documentation or publication somewhere explaining how these constants were calculated and defined?

For the array of 160 values (DSDFIR1_16_COEFS), I have been able to approach those values with a weighted sum of 8 cosines as defined here:
https://en.wikipedia.org/wiki/Window_function#Cosine-sum_windows
But I could not get to the exact values in your code.

The sum of the 160 values should be equal to 1<<28, but it is slightly more. Should all these values be reviewed?

Best regards.