Recent changes to bugs

Resizing Checkbox Cell To zero raises exception

Dancer42 — Fri, 25 Jul 2008 00:05:55 -0000

When a Checkbox cell is resized To zero an exception is raised on:
Viewbase.cs at:
SourceGrid.Cells.Views.ViewBase.DrawCell()
In the function call:
Draw(graphics, rectangle);

Exception Detail:
System.ArgumentException was unhandled
Message="Parameter is not valid."
Source="System.Drawing"
StackTrace:
at System.Drawing.Bitmap..ctor(Int32 width, Int32 height, PixelFormat format)
at System.Drawing.Bitmap..ctor(Int32 width, Int32 height)
at System.Windows.Forms.ControlPaint.DrawFrameControl(Graphics graphics, Int32 x, Int32 y, Int32 width, Int32 height, Int32 kind, Int32 state, Color foreColor, Color backColor)
at System.Windows.Forms.ControlPaint.DrawCheckBox(Graphics graphics, Int32 x, Int32 y, Int32 width, Int32 height, ButtonState state)
at System.Windows.Forms.ControlPaint.DrawCheckBox(Graphics graphics, Rectangle rectangle, ButtonState state)
at DevAge.Drawing.VisualElements.CheckBox.OnDraw(GraphicsCache graphics, RectangleF area)
at DevAge.Drawing.VisualElements.VisualElementBase.Draw(GraphicsCache graphics, RectangleF area, RectangleF& drawingArea)
at DevAge.Drawing.VisualElements.VisualElementBase.Draw(GraphicsCache graphics, RectangleF area)
at DevAge.Drawing.VisualElements.CheckBoxThemed.OnDraw(GraphicsCache graphics, RectangleF area)
at DevAge.Drawing.VisualElements.VisualElementBase.Draw(GraphicsCache graphics, RectangleF area, RectangleF& drawingArea)
at DevAge.Drawing.VisualElements.ContainerBase.OnDrawContent(GraphicsCache graphics, RectangleF area)
at DevAge.Drawing.VisualElements.ContainerBase.OnDraw(GraphicsCache graphics, RectangleF area)
at DevAge.Drawing.VisualElements.VisualElementBase.Draw(GraphicsCache graphics, RectangleF area, RectangleF& drawingArea)
at DevAge.Drawing.VisualElements.VisualElementBase.Draw(GraphicsCache graphics, RectangleF area)
at SourceGrid.Cells.Views.ViewBase.DrawCell(CellContext cellContext, GraphicsCache graphics, RectangleF rectangle) in C:\C#\SourceGrid4_11\SourceGrid\Cells\Views\ViewBase.cs:line 216
at SourceGrid.GridVirtual.PaintCell(GraphicsCache graphics, CellContext cellContext, RectangleF drawRectangle) in C:\C#\SourceGrid4_11\SourceGrid\Grids\GridVirtual.cs:line 1418
at SourceGrid.Grid.PaintCell(GraphicsCache graphics, CellContext cellContext, RectangleF drawRectangle) in C:\C#\SourceGrid4_11\SourceGrid\Grids\Grid.cs:line 519
at SourceGrid.GridVirtual.OnRangePaint(RangePaintEventArgs e) in C:\C#\SourceGrid4_11\SourceGrid\Grids\GridVirtual.cs:line 1382
at SourceGrid.Grid.OnRangePaint(RangePaintEventArgs e) in C:\C#\SourceGrid4_11\SourceGrid\Grids\Grid.cs:line 511
at SourceGrid.GridVirtual.OnPaint(PaintEventArgs e) in C:\C#\SourceGrid4_11\SourceGrid\Grids\GridVirtual.cs:line 1342
at System.Windows.Forms.Control.PaintWithErrorHandling(PaintEventArgs e, Int16 layer, Boolean disposeEventArgs)
at System.Windows.Forms.Control.WmPaint(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.DebuggableCallback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)
at System.Windows.Forms.UnsafeNativeMethods.DispatchMessageW(MSG& msg)
at System.Windows.Forms.Application.ComponentManager.System.Windows.Forms.UnsafeNativeMethods.IMsoComponentManager.FPushMessageLoop(Int32 dwComponentID, Int32 reason, Int32 pvLoopData)
at System.Windows.Forms.Application.ThreadContext.RunMessageLoopInner(Int32 reason, ApplicationContext context)
at System.Windows.Forms.Application.ThreadContext.RunMessageLoop(Int32 reason, ApplicationContext context)
at System.Windows.Forms.Application.Run(Form mainForm)
at AB.Program.Main() in C:\C#\AB\AB\Program.cs:line 18
at System.AppDomain._nExecuteAssembly(Assembly assembly, String[] args)
at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.ThreadHelper.ThreadStart()
InnerException:

Deleting Rows Bugfix

Davide Icardi — Fri, 11 Jul 2008 22:38:00 -0000

Hi,

I believe there's a bug in SourceGrid.Extensions\DataGrid.cs

The DeleteSelectedRows function deletes rows, one at a time according to their index, in ascending order. But as each row gets deleted, the higher rows "shuffle" down the list to fill the gap.

So with a list of 10 rows, indexed 0 to 9, deleting rows 2 to 4 will do the following:

Start with 0,1,2,3,4,5,6,7,8,9
Removing index 2 leaves 0,1,3,4,5,6,7,8,9
Removing index 3 at this point *actually removes row 4* leaving 0,1,3,5,6,7,8,9
Removing index 4 at this point removes row 6, leaving us with
0,1,3,5,7,8,9 when we actually expected
0,1,5,6,7,8,9

The fix is to delete the rows in reverse order. My version of DeleteSelectedRows is attached.

Cheers,

Tim

MaxSpan is not calculated

Alexander Mueller — Tue, 29 Apr 2008 10:18:14 -0000

The documentation of SourceGrid.Grid.MaxSpan tells me not to change the value since it is calculated automatically.

First, this value is shared between instances which isnt a nice thing and second, its only initialized to 10 and never changed from there.

So, do we really need MaxSpan? Yes, I have seen it is being used in some loops and tests. But the implementation just doesnt look right (shared variable across instances).

Improve Selection performance

Davide Icardi — Sat, 29 Mar 2008 23:29:46 -0000

What I changed is way of merging
RangeRegions - if you are sure that region you are
adding have no intersection with actual region,
you can omit some checks and increase performance.
See BOL comments.
Thanks to bladeblade for this code.
See also:
http://www.devage.com/Forum/ViewTopic.aspx?id=293d9cd8323a4251a9c5eecc59a5f0cf

See attach

Scrolling of large columns

Davide Icardi — Sat, 29 Mar 2008 13:30:20 -0000

if a column is stretched too far (out of the visible region) there seems to be a problem. It can't be reduced anymore and the horizontal scroll bar doesn't seem to work correctly.

Scrollbars scaling strangely

Davide Icardi — Sat, 17 Nov 2007 10:16:48 -0000

There is a problem when calculating the scroll bar pages. I must calculate the pages probably based on the visible rows (an average value).

See also message from lupokehl42:
http://www.devage.com/Forum/ViewTopic.aspx?id=e7df9aabb1274635b90acea511018712
""""""""""""""""""""""
I just did some tests with the Grid (latest Version, 4.10) and found that its scrollbars behave strangely.
The attached screenshot shows the demo program that comes with SourceGrid. Only one line (the last one) is out of view. But the scrollbar makes it look as if about one third of the contents were out of view.
This makes using the Grid very weird as soon as scrolling is involved, because I always feel as if there was much more data.

After some digging in the code, I think I found the problem.

CustomScrollControl.LoadScrollArea sets verticalPage and horizontalPage. These values are later fed to the scrollbars as LargeChange, so they should tell how many rows/columns are visible at a time.
The actual values come from GridVirtual.SetScrollArea(). And for reasons I do not understand, they are calculated as Math.Max(Rows.Count / 10, 1) and Math.Max(Columns.Count / 10, 1), respectively.
This makes the values far too small, which is why the scrollbars look as if the actual visible window was much smaller.

Replacing the function with the following code did the trick (although I'm still off by a bit because this does not consider the scrollbar sizes):

private void SetScrollArea()
{
// Calculate total height in pixels
int vSize = 0;
for (int i = 0; i < Rows.Count; i++)
vSize += Rows.GetHeight(i);

// Set vertPage as the average number of visible rows
int vertPage = (vSize > 0) ? Rows.Count * this.Height / vSize : 1;

// Calculate total width in pixels
int hSize = 0;
for (int i = 0; i < Columns.Count; i++)
hSize += Columns.GetWidth(i);

// Set horPage as the average number of visible columns
int horPage = (hSize > 0) ? Columns.Count * this.Width / hSize : 1;

LoadScrollArea(vertPage, horPage);
}
"""""""""""""""""""""

Multiselection bug after a dialog

Davide Icardi — Wed, 31 Oct 2007 23:15:29 -0000

double-click on a cell to change its value. When I click on any other cell to exit (and close the opened MsgBox) SourceGrid starts to begin some kind of MultiCellSelection beginning from the cell I clicked to exit the first one.

LinkedControl hide fixed rows/column

Davide Icardi — Tue, 23 Oct 2007 09:27:47 -0000

LinkedControls hide fixed rows or columns when scrolling.

Scrolling bug with hidden rows/columns

Davide Icardi — Tue, 09 Oct 2007 20:16:25 -0000

I noticed another bug in scrolling, related with 'hidden' rows.
Imagine I have grid with 100 rows, and rows between 50 and 80 are 'hidden'. When I scroll to 50th row, everything is fine, but to scroll to next visible row (80th) i have to scroll down 10 times (it depends from Windows configuration). The problem is obviously that scrolling detects 'hidden' rows, but I don't know how to fix it.

DataGrid error when changing DataSource

Wed, 03 Oct 2007 10:19:37 -0000

When adding new DataSource with new DataBoundView without removing and again adding DataGridColumns. DataGrid in all cells displays error that "column X does not belong to table Y"