timeconv funtcion buggy on leap year

Anonymous — Thu, 03 Jan 2008 14:20:20 -0000

The timeconv perl function , while using -n option is buggy on leap year : since 1st Jan add 86400 second too early
the correct code is attached

regards

Philippe de LUSSY

philippe.delussy@e-qual.fr

Comma-separated number display

Anonymous — Sat, 07 Oct 2006 01:46:06 -0000

This is both a bug + feature request, about using the
(currently unused) sub comma_sep to make the Max: value
shown in the graphs more readable.

The current sub generates:
e.g. 1 / 12 / 123 / 1234 / 12,345
^^^^
e.g. 123,456 / 1234,567 / 12,345,678
^^^^^^^^
Some time ago, I tweaked my copy of 3.1 to fix this. I
haven't noticed any problems.

The diff below is for v3.2:

$ diff squid-graph squid-graph-tweaked
1129a1130
> $graphMax = comma_sep($graphMax);
1207c1208
< if ((($len - $i - 1)%3 == 0) && ($i >
0) && ($i < $len - 1)) {
---
> if ((($len - $i - 1)%3 == 0) && ($i <
$len - 1)) {

Recent changes to bugs

timeconv funtcion buggy on leap year

Comma-separated number display