Recent changes to bugs

GetFullPathName missing check for errors. Empty filename?

Anonymous — Fri, 02 Jul 2010 12:09:31 -0000

The call to GetFullPathName in FFExpandFileName does not check the return result for errors. This appears to be masking a problem that occurs when an empty filename is given to FFExpandFileName. Sometimes when given an empty filename it seemed to return random data, but this problem changed in unpredictable ways and I just circumvented it rather than found the source of the problem. I have altered my FFExpandFileName to something like this to cure these problems:

function FFExpandFileName(const fn: TffFullFileName): TffFullFileName;
var
FNZ : TffMaxPathZ;
EFNZ : TffMaxPathZ;
FileNamePos : PAnsiChar;
i: integer;
err: integer;
begin
if Length(fn) = 0 then
Result := fn
else begin
i := GetFullPathName(FFStrPCopy(FNZ, fn), sizeof(EFNZ), EFNZ, FileNamePos);
if i = 0 then begin
err := GetLastError;
Exception.raise('FFExpandFileName error. ' + IntToStr(err) + ': ' + SysErrorMessage(err) + ' fn = ' + string(fn));
end;
Result := FFStrPasLimit(EFNZ, pred(sizeof(TffFullFileName)));
end;
end;

SetFilePointer error handling incorrect. Affects files > 2Gb

Anonymous — Sun, 20 Jun 2010 12:06:57 -0000

The SetFilePointer calls in fffile.inc in functions FFGetPositionFilePrim32, FFPositionFilePrim32 and FFPositionFileEOFPrim32 are followed by testing the result against $FFFFFFFF and raising an exception if equal. According to

http://msdn.microsoft.com/en-us/library/aa365541(VS.85).aspx

this is incorrect for files over 2Gb. It says :

"If the return value is INVALID_SET_FILE_POINTER and if lpDistanceToMoveHigh is non-NULL, an application must call GetLastError to determine whether or not the function has succeeded or failed."

"File may be in use by another process." ciReopenSleep = 100

Anonymous — Mon, 26 Apr 2010 11:20:30 -0000

FF2.13. Under heavy transaction load my users sometimes get "File could not be opened. File may be in use by another process." It happens more frequently when they have a virus checker switched on. I have changed the ciReopenSleep constant in ffsrbase.pas from 25ms to 100ms and have one data point which suggests this has cured the problem. This constant is used in FFForceFlushFile procedure to Sleep then retry the CreateFile command in FFOpenFilePrim when it fails the first time with an INVALID_HANDLE_VALUE result. (It might make sense to introduce a sequence of Sleep and retry commands with progressively longer Sleeps into the FFForceFlushFile procedure.) Maybe this is related to "File I/O error on Win2K Advanced Server - ID: 673411" which possibly, only guessing from the error message, might be an earlier incarnation of the same bug.

Explorer Importing CSV DateTime broken

Jeremy English — Mon, 29 Nov 2004 21:23:53 -0000

When importing a date Time field from a csv file using
the explorer I am only getting the Date portion.

I found and fixed the problem here:

The file ffimdlgf.pas has the following error

fftDateTime and fftSTDate are both getting set to
nftASCIIDate.

But, with dateTime you really want the date and the
time so you should set asourceType to nftASCIITimestamp.

Access Violation when choosing menu items.

Jeremy English — Wed, 02 Jun 2004 19:16:35 -0000

If a server is not selected in the lservers list you
will get an access violation when you select any of the
config menu's items. It looks like they tried to avoid
this problem by trapping the onclick event and
disabling the menu items. The onclick event only
response to a left click. So right clicking off of the
selected item in the list box will reproduce this error.

I made the following changes in the file Uffsmain.pas
to fix the problem.

procedure TfrmFFServer.lvServersMouseDown(Sender: TObject;
Button: TMouseButton; Shift: TShiftState; X, Y: Integer);
begin
lvServersClick(Sender); {-jeremy. added to fix is
server selected problem}
end;

duplicate index record in win9x

Ricardo Oliveira — Mon, 16 Jun 2003 15:16:14 -0000

im find a error when using server in win98. when i
browse records moving to next / prior in alphanumeric
indexes a duplication of index records occurs and a
corruption of the index and the data.

f213_r40 missing in ff2_d40.dpk

Anonymous — Thu, 03 Apr 2003 09:47:58 -0000

Trying to install the ff2 package in Delphi 4.

This package is missing:

f213_r40;

Solution:
Simply rename to

ff2_r40;

Database takes a long time to open

Anonymous — Wed, 02 Apr 2003 08:45:46 -0000

When I try to open the database the it takes a very long
time to do so when there is no Servername entered in
the LegacyTransport component. When I assign the
servername before opening it opens immediately.

This was not the case in Flash Filer 2.12 It would open
immediately if there was no servername entered.

Frederik Finck
Elbatron GmbH
finck@elbatron.de

UPPER clause in SQL causes error message

Anonymous — Wed, 02 Apr 2003 08:40:34 -0000

When I try to use the clause UPPER in a SQL
statement I get the error message : 'Query execution
failed. Variant is not an array.' When I remove the
UPPER clause from the statement it works fine.

The query worked with UPPER in Flash Filer 2.12.

Wrong field in join ends in an assertion

AmorWorx — Thu, 13 Feb 2003 18:09:18 -0000

Example:

select
pl.PONo as PONo,
coalesce(p.LotNo, '????') as LotNo,
pl.GrowerCode as GrowerCode,
pl.ItemCode as ItemCode,
coalesce(pl.Description, i.Description) as ItemDescr,
coalesce(pl.ShortDescription, i.ShortDescription) as
ItemShortDescr,
pl.ProductType as ProductType,
pt.ShortDescription as ProductTypeDescr,
pl.FlowerType as FlowerType,
ft.ShortDescription as FlowerTypeDescr,
pl.GradeCode as GradeCode,
g.Description as GradeDescr,
pl.Label as Label,
pl.Units as Units,
pl.Boxes as Boxes
from POLines pl
left join POs p on ((p.CompanyCode = '9999') and (p.No
= pl.PONo))
left join Items i on ((i.CompanyCode = '9999') and
(i.Code = pl.ItemCode))
left join ProductTypes pt on ((pt.CompanyCode = '9999')
and (pt.Code =
pl.ProductType))
left join FlowerTypes ft on ((ft.CompanyCode = '9999')
and (ft.Code =
pl.FlowerType))
left join Grades g on ((g.CompanyCode = '9999') and
(g.FlowerType =
ft.FlowerType) and (g.Code = pl.GradeCode))
where (pl.CompanyCode = '9999')
and (pl.PONo = '0000000001')

I get:

FlashFiler: Query624155046: Query execution failed:
Assertion failure (d:\opensource\ff2\source\ffsqldef.pas,
line 8223)
[$D538/54584]

The offending field here is ft.FlowerType in the join
clause (should have been ft.Code) I think that this
should have been an exception because the field isn't
part of the ft (FlowerTypes) table

Bert.