Recent changes to bugs

#43 InsertMenu(Item) cutting off entries after 75(?) chars

David — Mon, 07 Mar 2022 04:44:33 -0000

status: open --> closed-fixed

#43 InsertMenu(Item) cutting off entries after 75(?) chars

toxie — Sun, 06 Mar 2022 12:18:55 -0000

Great, thanks!

#43 InsertMenu(Item) cutting off entries after 75(?) chars

David — Sun, 06 Mar 2022 02:53:07 -0000

Hi toxie,

I've increased the text limit of menu items from 80 to 255 characters.
You can download the latest code snapshot from the code section here on SourceForge.

Best regards,
David

#43 InsertMenu(Item) cutting off entries after 75(?) chars

toxie — Sat, 05 Mar 2022 08:19:39 -0000

Oh man, sorry once more. 80 chars. :/

#43 InsertMenu(Item) cutting off entries after 75(?) chars

toxie — Sat, 05 Mar 2022 08:13:25 -0000

Sorry, 77 characters, not 75..

InsertMenu(Item) cutting off entries after 75(?) chars

toxie — Sat, 05 Mar 2022 08:09:05 -0000

Hi!
In Visual Pinball we see the issue that strings added via InsertMenu(Item) are being cutoff after (seemingly consistent?!) 75 characters. The original code (i.e. raw win32 UI code, before we redid all with win32++) worked perfectly, also the strings inserted via

     MENUITEMINFO menuInfo = {};
     menuInfo.cbSize = GetSizeofMenuItemInfo();
     menuInfo.fMask = MIIM_ID | MIIM_STRING | MIIM_STATE;
     menuInfo.fState = MFS_ENABLED;
     menuInfo.wID = RECENT_FIRST_MENU_IDM + (UINT)i;
     menuInfo.dwTypeData = recentMenuname;
     menuInfo.cch = strlen(recentMenuname);
     menuFile.InsertMenuItem(count, menuInfo, TRUE);

are looking good in the debugger. Also
menuFile.InsertMenu(count, MF_BYPOSITION | MF_ENABLED | MF_STRING, RECENT_FIRST_MENU_IDM + (UINT)i, recentMenuname);

shows the same issue. Attached screenshot shows the issue. First 3 (short) entries are good, all others are cut off.
Thanks!

InsertMenu(Item) cutting off entries after 75(?) chars

toxie — Sat, 05 Mar 2022 08:09:05 -0000

Ticket 43 has been modified: InsertMenu(Item) cutting off entries after 75(?) chars
Edited By: David (david_nash)
Status updated: 'open' => 'closed-fixed'

#42 Endless recursions in 4 functions

David — Fri, 07 Jan 2022 06:30:48 -0000

status: open-fixed --> closed-fixed

#42 Endless recursions in 4 functions

David — Mon, 08 Mar 2021 06:00:56 -0000

status: open --> open-fixed
assigned_to: David

#42 Endless recursions in 4 functions

David — Mon, 08 Mar 2021 05:59:58 -0000

Hi toxie,

Thanks for bringing this to my attention. I've submitted an update to the code which corrects the issues you've mentioned, and improves support for the Clang compiler.

Best regards,
David